Treat SIMPLE_PROGRAMS more like PROGRAM

RESOLVED FIXED in mozilla28

Status

Firefox Build System
General
RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla28
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 825139 [details] [diff] [review]
Treat SIMPLE_PROGRAMS more like PROGRAM
Attachment #825139 - Flags: review?(gps)
(Assignee)

Comment 2

5 years ago
Created attachment 825144 [details] [diff] [review]
Treat SIMPLE_PROGRAMS more like PROGRAM
Attachment #825144 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Attachment #825139 - Attachment is obsolete: true
Attachment #825139 - Flags: review?(gps)
(Assignee)

Comment 3

5 years ago
Comment on attachment 825144 [details] [diff] [review]
Treat SIMPLE_PROGRAMS more like PROGRAM

Since gps is on PTO, let's see if mshal can get here first.
Attachment #825144 - Flags: review?(mshal)
Comment on attachment 825144 [details] [diff] [review]
Treat SIMPLE_PROGRAMS more like PROGRAM

These changes look good to me.

Is there any reason to still require the files be in both SOURCES and SIMPLE_PROGRAMS? We could just do:

SIMPLE_PROGRAMS += [
    'bar.c',
    'foo.cpp',
]

And handle the rest in mozbuild.
Attachment #825144 - Flags: review?(mshal) → review+
(Assignee)

Updated

5 years ago
Attachment #825144 - Flags: review?(gps)
(Assignee)

Comment 5

5 years ago
(In reply to Michael Shal [:mshal] from comment #4)
> Is there any reason to still require the files be in both SOURCES and
> SIMPLE_PROGRAMS?

Let's do this in a followup.
https://hg.mozilla.org/mozilla-central/rev/c2e496209608
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.