933162 - Update in-urlbar icons

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Lucas Rocha (:lucasr)]

Attachment: Close button

They are still coming from the platform-specific themes which make them look a bit alien (see screenshots). I'd expect them to follow the same visual language than, say, the back and forward button.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Throbber

Comment 2

[Lucas Rocha (:lucasr)]

Same for the refresh/stop button btw.

Comment 3

[:Gijs (he/him)]

So the throbber, stop/reload button are tracked in bug 875479, and the close button in bug 879921.

Comment 4

[:Gijs (he/him)]

Actually, maybe we should keep this open for the stop/reload within the URL bar, as they're not part of Toolbar.png .

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

This bug can also be used for the throbber.

Comment 6

[Dão Gottwald [:dao]]

The throbber on Windows uses the green that's common for progress bars on Windows. The throbber on Linux uses the orange because there's really no single color that's going to fit all Linux themes and green felt natural at least on Ubuntu. Replacing it with the Windows throbber doesn't make sense.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #6)
> ... and green felt natural at least on Ubuntu.

"orange", of course

Comment 8

[Lucas Rocha (:lucasr)]

(In reply to Dão Gottwald [:dao] from comment #6)
> The throbber on Windows uses the green that's common for progress bars on
> Windows. The throbber on Linux uses the orange because there's really no
> single color that's going to fit all Linux themes and green felt natural at
> least on Ubuntu. Replacing it with the Windows throbber doesn't make sense.

My impression from Australis is that it's heading more in a direction of cross-platform consistency as opposed to strictly following each platform's visual language. For instance, the main menu items in Australis uses the same style across platforms, right? Same for things like download icon, back/forward buttons (?), and others.

I can't see how the close button and throbber are any different. For instance, the orange throbber look a bit alien in the Australis visual language. The same likely applies to the green throbber on Windows (but I haven't seen it, can't tell).

In other words, I'd expect Firefox with Australis to have a throbber and close button (and almost everything else) that follows the Australis visual style. Am I missing something?

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

To back up what Lucas is talking about, Stephen has used this throbber, http://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/images-general/spinner-connecting.png, in his new Windows 8 mockup (http://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/windows8.html).

So maybe we should be thinking about updating throbbers for all platforms (not necessarily using the same one) so that they match the other Australis redesigned iconography.

Comment 10

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] from comment #9)
> To back up what Lucas is talking about, Stephen has used this throbber,
> http://people.mozilla.org/~shorlander/mockups-interactive/australis-
> interactive-mockups/images-general/spinner-connecting.png, in his new
> Windows 8 mockup
> (http://people.mozilla.org/~shorlander/mockups-interactive/australis-
> interactive-mockups/windows8.html).

That only shows the connecting, not the loading state, and a mockup isn't necessarily a final design either -- it can just be a sign of Stephen playing around with ideas.

> So maybe we should be thinking about updating throbbers for all platforms
> (not necessarily using the same one) so that they match the other Australis
> redesigned iconography.

But that's orthogonal to this bug. If there's a plan to update throbbers on all platforms, that should be filed separately.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 12

[:Gijs (he/him)]

Comment on attachment 826001 [details] [diff] [review]
Patch

Review of attachment 826001 [details] [diff] [review]:
-----------------------------------------------------------------

Note that OS X has no hover styles. I guess Windows is closer, so it makes sense to copy that, but I figured I should note it.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/ux/rev/dfba75e38e6e

Comment 14

[Lucas Rocha (:lucasr)]

(In reply to Jared Wein [:jaws] from comment #13)
> https://hg.mozilla.org/projects/ux/rev/dfba75e38e6e

Thanks Jared! This patch doesn't update the 'close' button on tabs. Is that intentional? Just wondering if I should file a separate bug.

Comment 15

[:Gijs (he/him)]

(In reply to Lucas Rocha (:lucasr) from comment #14)
> (In reply to Jared Wein [:jaws] from comment #13)
> > https://hg.mozilla.org/projects/ux/rev/dfba75e38e6e
> 
> Thanks Jared! This patch doesn't update the 'close' button on tabs. Is that
> intentional? Just wondering if I should file a separate bug.

(In reply to :Gijs Kruitbosch from comment #3)
> So the throbber, stop/reload button are tracked in bug 875479, and the close
> button in bug 879921.

Comment 16

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/dfba75e38e6e