933176 - Skip "obviously" non-tools directories during the tools tier

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

The tools tier should not exist, I think we all agree. The sad reality is that it does, on the other hand, its use is mostly controlled. I suggest we don't make -C dir tools for all the directories that are not "obviously" tools dirs, which can be defined as having the is_tool_dir flag set, or having a Makefile.in containing more or less ".*tools.*::", which, IMHO, is safe enough.

Comment 1

[Mike Hommey [:glandium]]

Sadly, at the moment, there are two tools rules in config/rules.mk. One for XPI_PKGNAME, and one for INSTALL_EXTENSION_ID.

Comment 2

[Mike Hommey [:glandium]]

> or having a Makefile.in containing more or less ".*tools.*::", which, IMHO, is safe enough.

Actually, I think I can get rid of those.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Skip non-tools directories without variables in moz.build that are relevant to tools during this tier

With bug 929298 and bug 933145, there are no tools rules left in Makefile.in, and all variables affecting tools will be in moz.build..

Comment 4

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #3)
> Created attachment 826254 [details] [diff] [review]
> Skip non-tools directories without variables in moz.build that are relevant
> to tools during this tier
> 
> With bug 929298 and bug 933145

Err, bug 929298 and bug 934070.

Comment 5

[Mike Hommey [:glandium]]

While not exactly the same, bug 1043344 addressed this without having to wait for the last pieces of Makefile using tools targets.