933207 - B2G SMS & MMS: Fire system messages for the delivery reports

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V1

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

1.3+ for a committed 1.3 user story

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 825778 [details] [diff] [review]
Patch, V1

Review of attachment 825778 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/src/gonk/MmsService.js
@@ +1712,5 @@
>        // TODO bug 832140 handle !Components.isSuccessCode(aRv)
>  
>        let topic;
>        if (mmsStatus === MMS.MMS_PDU_STATUS_RETRIEVED) {
>          topic = kSmsDeliverySuccessObserverTopic;

How about add this.broadcastMmsSystemMessage(topic, aDomMessage); right here?

@@ +1723,5 @@
>  
> +      // Broadcasting a 'sms-delivery-success' system message to open apps.
> +      if (topic == kSmsDeliverySuccessObserverTopic) {
> +        this.broadcastMmsSystemMessage(topic, aDomMessage);
> +      }

Delete these lines.

Comment 4

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V2

Thanks for the review. r=ctai

Comment 5

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/b2g-inbound/rev/a048187c9151

Comment 6

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, follow-up

Sorry. Miss one bit. Carry on r=ctai.

Comment 7

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/b2g-inbound/rev/e5c4fedbce6f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a048187c9151
https://hg.mozilla.org/mozilla-central/rev/e5c4fedbce6f