933215 - Tiny scrollbars using the Dark Theme on Mac in the Source Editor with CodeMirror

Status: RESOLVED WORKSFORME

(DevTools :: Source Editor, defect, P3)

Description

[Rob Campbell [:rc] (:robcee)]

Attachment: Light Theme

Scrollbars look normal (in debugger's source view) with Light Theme selected. BUT! with the Dark Theme...

they tiny.

(see soon-to-be attached screens)

Comment 1

[Rob Campbell [:rc] (:robcee)]

Attachment: Dark Theme They Tiny!

Comment 2

[Paul Rouget [:paul]]

Meh. OSX is not supposed to use non-native floating scrollbars.

Comment 3

[Girish Sharma [:Optimizer]]

Only if you have floating scrollbars enabled.

Comment 4

[Trevor Rowbotham [:rowbot]]

The scrollbars are also completely missing on Windows (Win 7 x64) in the Debugger, Style Editor, and Network panels when using CodeMirror with the Dark Theme.  When using the Light Theme, the scrollbars are there, but they are the system default ones rather than the floating ones.

The Inspector panel is using the floating scrollbar with the Dark Theme, but it isn't as small as it is in Rob's screenshot.

Comment 5

[Anton Kovalyov (:anton)]

Trevor, I think we're already working on the issue you're experiencing. See bug 931041.

Brian, wanna take this bug? :)

Comment 6

[Girish Sharma [:Optimizer]]

Just a note here. What Rob is experiencing is not an issue, but the feature by design. The fact that Mac Book Pro has retina display, 8 px is waaaay small of a width. I think we should increase the width to 16 px overall on all OS..

Comment 7

[Paul Rouget [:paul]]

(In reply to Girish Sharma [:Optimizer] from comment #6)
> Just a note here. What Rob is experiencing is not an issue, but the feature
> by design. The fact that Mac Book Pro has retina display, 8 px is waaaay
> small of a width.

Retina display doesn't change anything. The size is the same on a normal display and a retina display.

> I think we should increase the width to 16 px overall on
> all OS..

Why not. 12px maybe. We could use: nsIDOMWindowUtils.getScrollbarSize()

Comment 8

[Girish Sharma [:Optimizer]]

(In reply to Paul Rouget [:paul] from comment #7)
> (In reply to Girish Sharma [:Optimizer] from comment #6)
> > Just a note here. What Rob is experiencing is not an issue, but the feature
> > by design. The fact that Mac Book Pro has retina display, 8 px is waaaay
> > small of a width.
> 
> Retina display doesn't change anything. The size is the same on a normal
> display and a retina display.

Sure, size in pixel is same, but size in mm is different as the dpi is high.

> > I think we should increase the width to 16 px overall on
> > all OS..
> 
> Why not. 12px maybe. We could use: nsIDOMWindowUtils.getScrollbarSize()

12 is also good.

Comment 9

[Paul Rouget [:paul]]

(In reply to Girish Sharma [:Optimizer] from comment #8)
> (In reply to Paul Rouget [:paul] from comment #7)
> > (In reply to Girish Sharma [:Optimizer] from comment #6)
> > > Just a note here. What Rob is experiencing is not an issue, but the feature
> > > by design. The fact that Mac Book Pro has retina display, 8 px is waaaay
> > > small of a width.
> > 
> > Retina display doesn't change anything. The size is the same on a normal
> > display and a retina display.
> 
> Sure, size in pixel is same, but size in mm is different as the dpi is high.

No. Size in mm is the same. Size in physical pixel is double.

On normal display, the size is 8 physical pixels.
On retina display, the size is 16 physical pixels.

Comment 10

[Brian Grinstead [:bgrins]]

This should be resolved by Bug 931041, correct?

Comment 11

[Girish Sharma [:Optimizer]]

(In reply to Brian Grinstead [:bgrins] from comment #10)
> This should be resolved by Bug 931041, correct?

No, that bug is that the scrollbars are totally missing
This bug is that when they are present, the width is very small.

I think we all are agreeing on 12px as the width of the scrollbars ?

Comment 12

[Brian Grinstead [:bgrins]]

So this is not CodeMirror related?  We are just wanting to make the floating scrollbars bigger on Mac?

Comment 13

[Girish Sharma [:Optimizer]]

Yes, and on every OS.

Comment 14

[Brian Grinstead [:bgrins]]

For reference, here are the current sizes of floating scrollbars: 

8px on OSX: https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/devtools/floating-scrollbars.css

10px on Linux: https://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/devtools/floating-scrollbars.css

10px on Windows: https://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/devtools/floating-scrollbars.css.

I can't ever figure out how to see the floating scrollbars, or else I would check and send screenshots of different sizes - I just don't see them.

Further, I'm pretty sure (but not positive) that the screenshot robcee sent in attachment 825264 [details] have the native scrollbars.  I just don't really know enough about this to make the changes.  Is there more information somewhere about floating vs. non floating scrollbars, when they are active, and how to enable them?

Comment 15

[Girish Sharma [:Optimizer]]

On Mac, if you can disable native overlaying scrollbars and somehow shift back to the scrollbars of 10.6 osx, you can see the floating scrollbars in action in dark theme

Comment 16

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I *think* this is resolved now ( except on OS X 10.10 Beta 1, see bug 1044258 )