Closed Bug 933267 Opened 12 years ago Closed 11 years ago

[e.me] Improve search result update when app installed

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: ranbena, Assigned: amirn)

Details

In this code piece, when an app is installed, if the search is visible, it'll redo the search to update the installed app list https://github.com/EverythingMe/gaia/blob/c85bdc17265be211cafa32c2af15e86d2d0d14ed/apps/homescreen/everything.me/js/Brain.js#L621 But it's not optimal. There's no reason to refresh all app providers (especially not cloud apps) nor use Brain for it. I suggest that we keep this logic inside installedApp.js.
Assignee: nobody → amirn
Status: NEW → ASSIGNED
Seems to me we only update the installed apps results. here Brain.js triggers onNewQuery: https://github.com/EverythingMe/gaia/blob/master/apps/homescreen/everything.me/js/Brain.js#L624 which only updates the installed apps: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/Results/ResultManager.js#L119 am I missing something?
Flags: needinfo?(ran)
It's already implemented. Though I have found a certain case where it doesn't seem like it. I'll file a separate bug.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(ran)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.