Closed Bug 933270 Opened 8 years ago Closed 8 years ago

Allow some xpcshell-tests to run in parallel

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 28.0

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
The attached patch removes some of the forced run-sequentially that were added to avoid bustage when parallel xpcshell-tests were enabled.

The tests I'm enabling to run in parallel are all ones that don't use the fake servers.

On my system, it saves about 5% on 5 minutes when running the xpcshell-tests specific to mailnews, so not much, but still an improvement.

I've only touched this at the directory level for now, we could probably do more later for being explicit about which tests do/don't need to be run in sequence (or just fix the fake servers), but we can leave them to other bugs or bug 905910.
Attachment #825310 - Flags: review?(Pidgeot18)
Comment on attachment 825310 [details] [diff] [review]
The fix

Review of attachment 825310 [details] [diff] [review]:
-----------------------------------------------------------------

I've tested a similar patch locally (minus the mail/* tests), and IIRC, all the other directories break when global parallellization is reenabled, so this looks good to me.
Attachment #825310 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/4a83d411ad62
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
You need to log in before you can comment on or make changes to this bug.