933273 - Prevent loading AddonManager in webbrowser actor when not explicitely needed

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Alexandre Poirot [:ochameau]]

Per bug 899052 comment 32, we can see that the AddonManager is loaded everytime we load the webbrowser actor. That is totally unexpected on b2g as the addon manager isn't supposed to be instaciated on device and it will use a bunch of memory for nothing.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Prevent loading AddonManager in webbrowser actor when not explicitely needed r=nfitzgerald

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Is this patch ready for review?  Would be good to get this fixed soon.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/c800ad2e84d2

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c800ad2e84d2

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 825314 [details] [diff] [review]
Prevent loading AddonManager in webbrowser actor when not explicitely needed r=nfitzgerald

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 899052
User impact if declined: Can't debug apps with the remote protocol (console, inspector, debugger) because of this unexpected exception being thrown.
Testing completed (on m-c, etc.): locally, confirmed to fix the reported issue on multiple different phones.
Risk to taking this patch (and alternatives if risky): limited due to small/conservative patch.
String or IDL/UUID changes made by this patch: none

This patch actually needs to be uplifted to b2g 26/1.2 but I haven't seen any approval flag for this branch?

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 825314 [details] [diff] [review]
Prevent loading AddonManager in webbrowser actor when not explicitely needed r=nfitzgerald

[Triage Comment]
also approving for aurora (27) uplift since we'll want to cover the bases there, assuming you can land this there as-is.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6047fcf502a7
https://hg.mozilla.org/releases/mozilla-beta/rev/216511295a98

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/216511295a98