Closed Bug 933273 Opened 7 years ago Closed 7 years ago
Prevent loading Addon
Manager in webbrowser actor when not explicitely needed
Per bug 899052 comment 32, we can see that the AddonManager is loaded everytime we load the webbrowser actor. That is totally unexpected on b2g as the addon manager isn't supposed to be instaciated on device and it will use a bunch of memory for nothing.
Is this patch ready for review? Would be good to get this fixed soon.
Attachment #825314 - Flags: review?(nfitzgerald)
Assignee: nobody → poirot.alex
Attachment #825314 - Flags: review?(nfitzgerald) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Comment on attachment 825314 [details] [diff] [review] Prevent loading AddonManager in webbrowser actor when not explicitely needed r=nfitzgerald [Approval Request Comment] Bug caused by (feature/regressing bug #): 899052 User impact if declined: Can't debug apps with the remote protocol (console, inspector, debugger) because of this unexpected exception being thrown. Testing completed (on m-c, etc.): locally, confirmed to fix the reported issue on multiple different phones. Risk to taking this patch (and alternatives if risky): limited due to small/conservative patch. String or IDL/UUID changes made by this patch: none This patch actually needs to be uplifted to b2g 26/1.2 but I haven't seen any approval flag for this branch?
Comment on attachment 825314 [details] [diff] [review] Prevent loading AddonManager in webbrowser actor when not explicitely needed r=nfitzgerald [Triage Comment] also approving for aurora (27) uplift since we'll want to cover the bases there, assuming you can land this there as-is.
You need to log in before you can comment on or make changes to this bug.