Printing broken on OpenVMS

VERIFIED FIXED

Status

()

--
blocker
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: colin, Assigned: dcone)

Tracking

Trunk
DEC
OpenVMS
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: awaiting super-review)

Attachments

(3 attachments)

(Reporter)

Description

18 years ago
A recent change in nsPostScriptObj.cpp broke printing on OpenVMS (the OpenVMS
code got put into an else clause that never gets executed).

I have a patch and will submit it. Can someone check it in to the trunk?
(Reporter)

Comment 1

18 years ago
Created attachment 44462 [details] [diff] [review]
Move closing brace to BEFORE VMS code
(Assignee)

Comment 2

18 years ago
can you paste in the snippet of code.. not the diffs so I can see what 
happened.. I can tell from that diff.. and the patch utility, well I have never 
been able to get that to work consistently.. because of all different versions.. 
etc.. 
(Reporter)

Comment 3

18 years ago
The {} for the else got added around the VMS ifdef. That's the problem!
(Assignee)

Comment 4

18 years ago
r=dcone
(Reporter)

Comment 5

17 years ago
Attaching new (identical) patch for the trunk. Note that the only functional
change is to move the closing paren; the rest of the changes are just playing
with the indentation.

Will mail Brendan for a super-review.
(Reporter)

Comment 6

17 years ago
Created attachment 44794 [details] [diff] [review]
Patch for the trunk
(Reporter)

Updated

17 years ago
Whiteboard: awaiting super-review

Comment 7

17 years ago
Use PR_snprintf() to avoid buffer overrun.
(Reporter)

Comment 8

17 years ago
Created attachment 45093 [details] [diff] [review]
New patch using PR_snprintf

Comment 9

17 years ago
Thanks, only one more question...do we leak |mPrintSetup->filename| on every
platform but OpenVMS? Or are we free()-ing it twice here? ;-)
(Reporter)

Comment 10

17 years ago
On OpenVMS, if we're dealing with a real printer, then filename gets set to
an address that comes back from tempnam(). This needs free'ing. On other 
platforms the contents of filename shouldn't be free'd.
(Reporter)

Comment 11

17 years ago
Chris, could I trouble you for an sr= on this one?

Thanks, Colin.

Comment 12

17 years ago
gotcha, sr=waterson
(Reporter)

Comment 13

17 years ago
Checked in. Marking fixed.

For the record, its fixed on the trunk (M0.9.4). I fixed my local M0.9.3 build
before submitting the OpenVMS M0.9.3 build to Mozilla/Compaq.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 14

17 years ago
Colin, can you verify this and mark this bug VERIFIED? thanks..
(Reporter)

Comment 15

17 years ago
My fix is in. Marking verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.