93331 - Printing broken on OpenVMS

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Colin Blake]

A recent change in nsPostScriptObj.cpp broke printing on OpenVMS (the OpenVMS
code got put into an else clause that never gets executed).

I have a patch and will submit it. Can someone check it in to the trunk?

Comment 1

[Colin Blake]

Attachment: Move closing brace to BEFORE VMS code

Comment 2

[dcone (gone)]

can you paste in the snippet of code.. not the diffs so I can see what 
happened.. I can tell from that diff.. and the patch utility, well I have never 
been able to get that to work consistently.. because of all different versions.. 
etc.. 

Comment 3

[Colin Blake]

The {} for the else got added around the VMS ifdef. That's the problem!

Comment 4

[dcone (gone)]

r=dcone

Comment 5

[Colin Blake]

Attaching new (identical) patch for the trunk. Note that the only functional
change is to move the closing paren; the rest of the changes are just playing
with the indentation.

Will mail Brendan for a super-review.

Comment 6

[Colin Blake]

Attachment: Patch for the trunk

Comment 7

[Chris Waterson]

Use PR_snprintf() to avoid buffer overrun.

Comment 8

[Colin Blake]

Attachment: New patch using PR_snprintf

Comment 9

[Chris Waterson]

Thanks, only one more question...do we leak |mPrintSetup->filename| on every
platform but OpenVMS? Or are we free()-ing it twice here? ;-)

Comment 10

[Colin Blake]

On OpenVMS, if we're dealing with a real printer, then filename gets set to
an address that comes back from tempnam(). This needs free'ing. On other 
platforms the contents of filename shouldn't be free'd.

Comment 11

[Colin Blake]

Chris, could I trouble you for an sr= on this one?

Thanks, Colin.

Comment 12

[Chris Waterson]

gotcha, sr=waterson

Comment 13

[Colin Blake]

Checked in. Marking fixed.

For the record, its fixed on the trunk (M0.9.4). I fixed my local M0.9.3 build
before submitting the OpenVMS M0.9.3 build to Mozilla/Compaq.

Comment 14

[sujay]

Colin, can you verify this and mark this bug VERIFIED? thanks..

Comment 15

[Colin Blake]

My fix is in. Marking verified.