933320 - properly cross-compile WebRTC

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Nathan Froyd [:froydnj]]

Over in bug 921040, we're trying to compile Firefox for Mac on a Linux host.  There's no special logic in the Mozilla build system to tell WebRTC that we're cross-compiling.

I think I have this nailed for the darwin-cross case; I'll have to make the patch more general before it's ready, though.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - make find_sdk.py silently comply if we're not running on a Mac host

This part doesn't work if you don't specify --with-macos-sdk on the configure
line.  I'm not sure how to deal with that, and I am seeking feedback for how
to bend gyp to my will.

Nominating Ted, because he might understand gyp.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - inform WebRTC of our chosen target when invoking gyp

Let's not assume host==target when compiling WebRTC.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: part 2 - inform WebRTC of our chosen target when invoking gyp

Let's not assume host==target and let's not assume we know where our sdk is.

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: part 1 - make find_sdk.py silently comply if we're not running on a Mac host

Turns out we don't have to do any violence to the gyp files.  We just have to
make find_sdk.py not complain and silently return a bogus valuein such cases.
People compiling for OS X and not setting --with-macos-sdk get what they
deserve.

Comment 5

[Nathan Froyd [:froydnj]]

Attachment: part 2 - inform WebRTC of our chosen target when invoking gyp

Same patch as before, but using the "correct" mac_sdk_path gyp variable, rather than
the subtly different mac_sdk gyp variable.  No functional change.

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 828709 [details] [diff] [review]
part 2 - inform WebRTC of our chosen target when invoking gyp

Whoops, meant to carry over ted's r+ on this one.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 828708 [details] [diff] [review]
part 1 - make find_sdk.py silently comply if we're not running on a Mac host

Review of attachment 828708 [details] [diff] [review]:
-----------------------------------------------------------------

This probably needs to go upstream.

Comment 8

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/332629e90914
https://hg.mozilla.org/integration/mozilla-inbound/rev/8661635e53c2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/332629e90914
https://hg.mozilla.org/mozilla-central/rev/8661635e53c2

Comment 10

[Oleg Romashin (:romaxa)]

hmm this broke webrtc compilation on linux arm target... is anything need to be done to make it works back?