933443 - TypeError: columns is undefined @ https://crash-stats.allizom.org/static/CACHE/js/ff532ddaa571.js:39 when no table exists

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screen Shot 2013-10-31 at 1.49.15 PM.png

STR:

1. Load https://crash-stats.allizom.org/report/list?product=Firefox&query_search=signature&query_type=contains&reason_type=contains&date=2013-10-31&range_value=7&range_unit=days&hang_type=any&process_type=any&signature=%60anonymous+namespace%27%27%3A%3ASortComparatorFunction%3A%3Aoperator%28%29%28JS%3A%3AValue+const with the Web Console open and JS exceptions showing
2. Look in the Web Console

Actual Results:

[13:50:32.619] TypeError: columns is undefined @ https://crash-stats.allizom.org/static/CACHE/js/ff532ddaa571.js:39

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/1460ccfae226d7a333e1e43265272d791b43be16
Fix Bug 933443, do not show urls table or execute JS when there are no results

https://github.com/mozilla/socorro/commit/51fc783017f51f14e677b72f70d22e13cefe6b1b
Merge pull request #1644 from ossreleasefeed/bug933443-do-not-show-table-call-tablesorter-for-no-results

Fix Bug 933443, do not show urls table or execute JS when there are no results

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry, but I can still reproduce this (tried fresh browser instances/cleared cache, etc.).  Reopening.

Comment 3

[Schalk Neethling [:espressive]]

(In reply to Stephen Donner [:stephend] from comment #2)
> Sorry, but I can still reproduce this (tried fresh browser instances/cleared
> cache, etc.).  Reopening.

Ok I see, so this is the same problem but happens on many of the tabs not just the URLs one where all the focus has been.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c4925f4805f3d9afad42a9cc7912fdeae7fee683
Fix Bug 933443, avoid calling tablesorter when there is no table and other ongoing cleanup

https://github.com/mozilla/socorro/commit/49f0c02ed10b4fc40f771182cef390a928c3a88a
Merge pull request #1659 from ossreleasefeed/bug933443-do-not-show-table-call-tablesorter-for-no-results

Fix Bug 933443, avoid calling tablesorter when there is no table and other ongoing cleanup

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx; verified fixed on staging:

https://crash-stats.allizom.org/report/list?product=Firefox&query_search=signature&query_type=contains&reason_type=contains&date=2013-10-31&range_value=7&range_unit=days&hang_type=any&process_type=any&signature=%60anonymous+namespace%27%27%3A%3ASortComparatorFunction%3A%3Aoperator%28%29%28JS%3A%3AValue+const

No JS error.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot, on staging