933463 - Carrier selection affects curated collections even though there is no obvious way to select carriers for Curated collections

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: API, defect, P4)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/curation?carrier=&category&region=pl
2. Click on 'Create a collection' under curated collections
3. Note that the form has no option to select carriers
4. Create a new curated collection

expected behavior:
Since there is no option to select carrier info in the form, curated collections for a region show up irrespective of region info.

OR

Provide the option to select carrier info in the form to create a new curated collection.

observed behavior:
https://marketplace-dev.allizom.org/curation?carrier=deutsche_telekom&category&region=pl has no curated collection but 
https://marketplace-dev.allizom.org/curation?carrier=&category&region=pl does

ashes: ID: 6f5f3

Comment 1

[Matt Basta [:basta]]

This sounds like a bug in the API's fallback mechanism, if anything. Curated collections should not be available on a per-carrier basis, only FACs and OSCs are. It's more likely, from what I can tell, that it's a caching issue and what you were seeing was just caching lag.

I see no curated collections for either of the above URLs. Can you still reproduce the issue?

Also, what are those logs for? Which of those URLs does it apply to, or both?

Comment 2

[Mathieu Pillard [:mat]]

I can confirm that at the moment in the API, no special treatment is applied to any collection type. This means that filtering on region, category and carrier is always enabled, as well as the fallback mechanism, for every collection type.

Sounds like you want us to modify how it works for basic (non FACs, non OSCs) collections only. To recap just to be sure:
- Which filters should we disable for those ?
- Should we disable the fallback mechanism as well ?
- Should this affect rocketfuel only or search/featured endpoint as well? (search/featured returns one of each collection type atm)

Comment 3

[Matt Basta [:basta]]

(In reply to Mathieu Pillard [:mat] from comment #2)
> I can confirm that at the moment in the API, no special treatment is applied
> to any collection type. This means that filtering on region, category and
> carrier is always enabled, as well as the fallback mechanism, for every
> collection type.

That's my understanding as well.

> Sounds like you want us to modify how it works for basic (non FACs, non
> OSCs) collections only. To recap just to be sure:
> - Which filters should we disable for those ?
> - Should we disable the fallback mechanism as well ?
> - Should this affect rocketfuel only or search/featured endpoint as well?
> (search/featured returns one of each collection type atm)

Assuming what I think is implemented is actually implemented, I think the current behavior is correct. I'm unsure of what caused the behavior that krupa experienced, but my suspicion is caching lag since I can't reproduce it. If caching is indeed the culprit, this would be testable by visiting one particular filter first (set region X, then carrier Y), then creating a curated collection for that region, then filtering for region X without carrier Y. You wouldn't see the collection, but you would see it if you then applied the carrier Y filter (we're able to do cache rewriting).

Krupa: please provide reliable STR and/or logs. We can't debug this further if we're running on hearsay.

Comment 4

[Matt Basta [:basta]]

(In reply to Matt Basta [:basta] from comment #3)
> particular filter first (set region X, then carrier Y)

Sorry, I got that backwards. Carrier first, then region.

Comment 5

[krupa raj[:krupa]]

This issue is still reproducible but is rendered obsolete with the new Feed changes. Closing as wontfix