933563 - Consolidate ReportUseOfDeprecatedMethod and WarnOnceAbout

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The two seem to have exactly the same goal. And if we fix bug 933042 we get telemetry for both.

Comment 1

[Vendelin Ruzicka [:vendo]]

Attachment: bug933563

patch

Comment 2

[Jan Varga [:janv]]

With this patch everything is reported as "DOM Core" instead of DOM Events/DOM3 Load. I assume it doesn't matter. Otherwise, it looks good to me.

Comment 3

[Vendelin Ruzicka [:vendo]]

Attachment: bug933563

updated to tip, document.load() lower cased

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Actually, can we avoid the key change for the strings?

Comment 5

[Vendelin Ruzicka [:vendo]]

Attachment: bug933563

updated, previous version of strings used

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 830254 [details] [diff] [review]
bug933563

Review of attachment 830254 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, the main annoyance is changing the *key*, like UseOfCaptureEventsWarning -> CaptureEventsWarning. It would be better to use eUseOfCaptureEvents, so the key doesn't need to change.

Comment 7

[Vendelin Ruzicka [:vendo]]

Attachment: bug933563

ok, patch updated

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 830284 [details] [diff] [review]
bug933563

Review of attachment 830284 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3741313785b

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a3741313785b