Closed Bug 933563 Opened 6 years ago Closed 6 years ago

Consolidate ReportUseOfDeprecatedMethod and WarnOnceAbout

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: sicking, Assigned: vendo)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 3 obsolete files)

The two seem to have exactly the same goal. And if we fix bug 933042 we get telemetry for both.
Assignee: nobody → vendo.ruzicka
Attached patch bug933563 (obsolete) — Splinter Review
patch
Attachment #826158 - Flags: review?(jonas)
With this patch everything is reported as "DOM Core" instead of DOM Events/DOM3 Load. I assume it doesn't matter. Otherwise, it looks good to me.
Attachment #826158 - Flags: review?(jonas) → review+
Status: NEW → ASSIGNED
Attached patch bug933563 (obsolete) — Splinter Review
updated to tip, document.load() lower cased
Attachment #826158 - Attachment is obsolete: true
Attachment #828295 - Flags: review?(jonas)
Attachment #828295 - Flags: review?(jonas) → review+
Actually, can we avoid the key change for the strings?
Attached patch bug933563 (obsolete) — Splinter Review
updated, previous version of strings used
Attachment #828295 - Attachment is obsolete: true
Attachment #830254 - Flags: review?(Ms2ger)
Comment on attachment 830254 [details] [diff] [review]
bug933563

Review of attachment 830254 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, the main annoyance is changing the *key*, like UseOfCaptureEventsWarning -> CaptureEventsWarning. It would be better to use eUseOfCaptureEvents, so the key doesn't need to change.
Attachment #830254 - Flags: review?(Ms2ger)
Attached patch bug933563Splinter Review
ok, patch updated
Attachment #830254 - Attachment is obsolete: true
Attachment #830284 - Flags: review?(Ms2ger)
Comment on attachment 830284 [details] [diff] [review]
bug933563

Review of attachment 830284 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks!
Attachment #830284 - Flags: review?(Ms2ger) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a3741313785b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.