933584 - Implement DrawTargetSkia::OptimizeSourceSurface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Andreas Gal :gal]

Attachment: Turn any source surface into a skia source surface by re-creating it via GetDataSurface().

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 825703 [details] [diff] [review]
Turn any source surface into a skia source surface by re-creating it via GetDataSurface().

Review of attachment 825703 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good for the most part, r=me with my comment fixed.

::: gfx/2d/DrawTargetSkia.cpp
@@ +641,5 @@
>  {
> +  if (aSurface->GetType() == SURFACE_SKIA) {
> +    return aSurface;
> +  }
> +

We should only do this if GetType() == SURFACE_DATA. Otherwise we're supporting interop between DT types, which is an explicit non-goal for moz2d.

The 2D.h comment for this could probably be better here. My understanding is that it optimizes a surface for this instance of a DT, not converts between backend types.

Comment 3

[Andreas Gal :gal]

It feels wrong to break this if it just works, but anything that gets me an r+.

Comment 4

[Andreas Gal :gal]

The comment in 2D.h really, really disagrees with you. "arbitrary"

   * Create a SourceSurface optimized for use with this DrawTarget from                                                                                                         
   * an arbitrary other SourceSurface. This may return aSourceSurface or some                                                                                                   
   * other existing surface.

Comment 5

[Andreas Gal :gal]

Attachment: Implement OptimizeSourceSurface for skia (r=mattwoodrow).

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f086c46a2f5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3f086c46a2f5