933605 - Some pldhash clean-ups

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

I got me some pldhash clean-ups in hand, yes I do.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove DEBUG_XXXbrendan-only code.

I too sometimes write ad hoc profiling code.  But I don't *land* it.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Don't declare all vars at the top of functions in pldhash.cpp.

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 825747 [details] [diff] [review]
(part 2) - Don't declare all vars at the top of functions in pldhash.cpp.

Review of attachment 825747 [details] [diff] [review]:
-----------------------------------------------------------------

All right.

::: xpcom/glue/pldhash.cpp
@@ +562,2 @@
>  
> +      case PL_DHASH_REMOVE: {

The curly braces aren't used here.

@@ +596,5 @@
>      ABORT_UNLESS(table->recursionLevel != IMMUTABLE_RECURSION_LEVEL);
>  
>      NS_ASSERTION(PL_DHASH_ENTRY_IS_LIVE(entry),
>                   "PL_DHASH_ENTRY_IS_LIVE(entry)");
> +    /* Load keyHash first in case clearEntry() goofs it. */

Style nit: blank line before comment (except at the top of a block).

@@ +728,2 @@
>      double sqsum, mean, variance, sigma;
> +    PLDHashEntryHdr *entry;

Heh. It's a little weird that you fixed all the others but not these!

Comment 4

[Nicholas Nethercote [inactive]]

> @@ +728,2 @@
> >      double sqsum, mean, variance, sigma;
> > +    PLDHashEntryHdr *entry;
> 
> Heh. It's a little weird that you fixed all the others but not these!

They're each used in two separate parts of the function, so the top was as good a place as any for them.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95af1e72abff
https://hg.mozilla.org/integration/mozilla-inbound/rev/56fc3fc6a42a

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95af1e72abff
https://hg.mozilla.org/mozilla-central/rev/56fc3fc6a42a