933646 - Blackboxing a program in the shader editor should, in fact, hide the rendered geometry, not create black holes

Status: RESOLVED FIXED

(DevTools Graveyard :: WebGL Shader Editor, defect, P2)

Description

[Victor Porof [:vporof][:vp]]

Right now it replaces it with (supposedly) transparent black.

However, depending on the webgl context state, especially when alpha blending is disabled, it won't work, drawing it as opaque black. This is ANNOYING.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: webgl-blackbox.patch

Would like to land this on aurora before the Hacks blog post on 11th.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: webgl-blackbox.patch

Rebased to land this first.

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/6cbc5a5a177f

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/eb06bfe7f9b6 for breaking xpcshell tests like this https://tbpl.mozilla.org/php/getParsedLog.php?id=30097045&tree=Fx-Team

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Wes Kocher (:KWierso) from comment #4)
> Backed out in https://hg.mozilla.org/integration/fx-team/rev/eb06bfe7f9b6
> for breaking xpcshell tests like this
> https://tbpl.mozilla.org/php/getParsedLog.php?id=30097045&tree=Fx-Team

Damn strict warnings !!

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/64e809f87e60

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 826962 [details] [diff] [review]
webgl-blackbox.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature!
User impact if declined: Some minor-ish functionality for the Shader Editor will be confusing or useless.
Testing completed (on m-c, etc.): locally, fx-team
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None

Comment 8

[bhavana bajaj [:bajaj]]

(In reply to Victor Porof [:vp] from comment #6)
> https://hg.mozilla.org/integration/fx-team/rev/64e809f87e60

Can you confirm what versions of firefox versions are affected here by setting the status flags. Unclear from the blocking bug.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/64e809f87e60

Comment 10

[Victor Porof [:vporof][:vp]]

(In reply to bhavana bajaj [:bajaj] from comment #8)
> (In reply to Victor Porof [:vp] from comment #6)
> > https://hg.mozilla.org/integration/fx-team/rev/64e809f87e60
> 
> Can you confirm what versions of firefox versions are affected here by
> setting the status flags. Unclear from the blocking bug.

Bug 930928 also has an aurora approval request.

Comment 11

[Bogdan Maris, Desktop Test Engineering]

I see that this bug has in-testsuite+. Is there any help needed for manual testing here? If yes can you please provide some steps in order to reproduce and verify that this is fixed?

Comment 12

[Victor Porof [:vporof][:vp]]

There are automated tests for this.

Comment 13

[Ada [:adalucinet]]

Based on comment 12: deleting verifyme keyword.