Closed
Bug 933646
Opened 11 years ago
Closed 11 years ago
Blackboxing a program in the shader editor should, in fact, hide the rendered geometry, not create black holes
Categories
(DevTools Graveyard :: WebGL Shader Editor, defect, P2)
DevTools Graveyard
WebGL Shader Editor
Tracking
(firefox26 unaffected, firefox27 fixed, firefox28 fixed)
RESOLVED
FIXED
Firefox 28
Tracking | Status | |
---|---|---|
firefox26 | --- | unaffected |
firefox27 | --- | fixed |
firefox28 | --- | fixed |
People
(Reporter: vporof, Assigned: vporof)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
35.74 KB,
patch
|
vporof
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Right now it replaces it with (supposedly) transparent black. However, depending on the webgl context state, especially when alpha blending is disabled, it won't work, drawing it as opaque black. This is ANNOYING.
Assignee | ||
Comment 1•11 years ago
|
||
Would like to land this on aurora before the Hacks blog post on 11th.
Assignee | ||
Updated•11 years ago
|
Priority: -- → P2
Assignee | ||
Updated•11 years ago
|
Summary: Blacboxing a program in the shader editor should, in fact, hide the rendered geometry, not create black holes → Blackboxing a program in the shader editor should, in fact, hide the rendered geometry, not create black holes
Assignee | ||
Updated•11 years ago
|
Attachment #825764 -
Flags: review?(dcamp) → review?(rcampbell)
Updated•11 years ago
|
Attachment #825764 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Rebased to land this first.
Attachment #825764 -
Attachment is obsolete: true
Attachment #826962 -
Flags: review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6cbc5a5a177f
Whiteboard: [fixed-in-fx-team]
Backed out in https://hg.mozilla.org/integration/fx-team/rev/eb06bfe7f9b6 for breaking xpcshell tests like this https://tbpl.mozilla.org/php/getParsedLog.php?id=30097045&tree=Fx-Team
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #4) > Backed out in https://hg.mozilla.org/integration/fx-team/rev/eb06bfe7f9b6 > for breaking xpcshell tests like this > https://tbpl.mozilla.org/php/getParsedLog.php?id=30097045&tree=Fx-Team Damn strict warnings !!
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/64e809f87e60
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 826962 [details] [diff] [review] webgl-blackbox.patch [Approval Request Comment] Bug caused by (feature/regressing bug #): New feature! User impact if declined: Some minor-ish functionality for the Shader Editor will be confusing or useless. Testing completed (on m-c, etc.): locally, fx-team Risk to taking this patch (and alternatives if risky): None String or IDL/UUID changes made by this patch: None
Attachment #826962 -
Flags: approval-mozilla-aurora?
Comment 8•11 years ago
|
||
(In reply to Victor Porof [:vp] from comment #6) > https://hg.mozilla.org/integration/fx-team/rev/64e809f87e60 Can you confirm what versions of firefox versions are affected here by setting the status flags. Unclear from the blocking bug.
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/64e809f87e60
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to bhavana bajaj [:bajaj] from comment #8) > (In reply to Victor Porof [:vp] from comment #6) > > https://hg.mozilla.org/integration/fx-team/rev/64e809f87e60 > > Can you confirm what versions of firefox versions are affected here by > setting the status flags. Unclear from the blocking bug. Bug 930928 also has an aurora approval request.
status-firefox27:
--- → affected
Updated•11 years ago
|
status-firefox26:
--- → unaffected
status-firefox28:
--- → fixed
Updated•11 years ago
|
Attachment #826962 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•11 years ago
|
Comment 11•11 years ago
|
||
I see that this bug has in-testsuite+. Is there any help needed for manual testing here? If yes can you please provide some steps in order to reproduce and verify that this is fixed?
Flags: needinfo?(vporof)
Comment 13•10 years ago
|
||
Based on comment 12: deleting verifyme keyword.
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•