93365 - <font face=arial> only goes through tables when all tags are closed

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Jesse Ruderman]

<font face=arial> is applied to a table inside the font tag only if both of the 
following are true:

1. all tags inside the table are closed
2. the font tag is closed

Comment 1

[Jesse Ruderman]

Attachment: testcase for 1: all tags inside the table must be closed

Comment 2

[Jesse Ruderman]

Attachment: testcase for 2: font tag must be closed

Comment 3

[Jesse Ruderman]

Forgot to mention: I split this from bugscape 5639.

Comment 4

[harishd]

Looks like IE allows FONT to contain TABLE! If I do the same then everything (
well almost! ) seems to work fine. It's impressive that IE retains the content
model intact even when handling qurikyness. That is, try the example below

<font>
 <b><i>
</font>
 bold </b>
 italic </i>

In N6 content model looks like 
 <font>
  <b><i></i></b>
 </font>
  <b>bold</b>
  <i>italic</b>

and in IE it looks exactly the same as the document source!

Comment 5

[harishd]

I need to talk to Marc Attinasi about letting FONT to contain TABLE. 

FYI: When I did so in quirks mode we render almost the same as IE however in
strict mode we look completely different!!!!!

Comment 6

[harishd]

Attachment: Test case [ strict mode ]

Comment 7

[harishd]

CCing 

Comment 8

[Marc Attinasi]

yea, IE seems to keep the original document model for DOM access and selector
matching, and also a fixed up one for rendering - very interesting indeed.

Comment 9

[harishd]

Attachment: Patch v1.1 [ Allow FONT to contain TABLE ]

Comment 10

[harishd]

The above patch would allow font properties to propagate into TABLE..however, in
order to emulate IE we need to find out what properties can and cannot propagate.

Note: FONT color property does not propagate inside TABLE on the trunk ( just
like IE ) but does on the branch ( this needs to be fixed ).

Comment 11

[Johnny Stenback (:jst)]

sr=jst

Comment 12

[Heikki Toivonen (remove -bugzilla when emailing directly)]

r=heikki

Comment 13

[Hixie (not reading bugmail)]

harish: That would be hyatt's area (he changed the way we block off inheritance
on tables with his rulenode landing).

hyatt: see harish's comments above.

Comment 14

[harishd]

Attachment: Compare this document against IE

Comment 15

[harishd]

Need to control properties that can propagate inside TABLE. This should happen
in Layout. Giving bug to Marc Attinasi.

Comment 16

[Marc Attinasi]

Right - we need to update the style-inheriting-into-tables quirk on the BRANCH.

Comment 17

[Marc Attinasi]

Attachment: Patch to apply the fix to the branch (is already on the trunk)

Comment 18

[Marc Attinasi]

I've attached a pathc that makes the fix - it was done by Hyatt on the trunk, I
just applied it to my branch and tested it (it works, of course).

Comment 19

[Marc Attinasi]

Checked in to BRANCH Hyatt's fixes that have been on trunk for a while now:

/cvsroot/mozilla/content/html/style/src/nsHTMLStyleSheet.cpp,v  <-- 
nsHTMLStyleSheet.cpp
new revision: 3.218.14.1; previous revision: 3.218

/cvsroot/mozilla/content/html/style/src/nsRuleNode.cpp,v  <--  nsRuleNode.cpp
new revision: 3.4.2.2; previous revision: 3.4.2.1

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

For the record, the branch also needed the fix to bug 93270 (a crasher caused by
hyatt's fix above), which I'm about to move over to it as well.

Comment 21

[Moied]

Verified with build ID 20011115 on win2k, Marking verified.