933688 - NSS: certutil should allow shell script or user to set empty password non-interactively when creating certificate database using -N option

Status: RESOLVED FIXED

(NSS :: Tools, defect)

Description

[Eric Wong]

Attachment: Patch: add a "--empty-password" option to set the empty password non-interactively when creating cert database using -N command

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130911164256

Steps to reproduce:

# mkdir test
# certutil -N -d ./test



Actual results:

# mkdir test
# certutil -N -d ./test
Enter a password which will be used to encrypt your keys.
The password should be at least 8 characters long,
and should contain at least one non-alphabetic character.

Enter new password:
Re-enter password:



Expected results:

# mkdir test
# certutil -N -d ./test --empty-password
#

Comment 1

[Loic]

You need to request reviewing when you attach a patch. ;)

Comment 2

[Eric Wong]

(In reply to Loic from comment #1)
> You need to request reviewing when you attach a patch. ;)

Thanks for your note, I am new to bugzilla system and I also sent an email to one of the reviewer(from the log of hg repository)

Comment 3

[Kai Engert (:KaiE:)]

I'm cc'ing Bob and Wan-Teh, in case they want to veto.

I think your proposal is reasonable.

It's already possible to create a database with an empty password automatically, by using a password file that contains a newline only, e.g. as created using:
  echo > password-file

Nevertheless, in my opinion the parameter you propose is an improvement, because it makes it more easily discoverable how to do it.

I looked at your patch, and it seems correct to me. However, I'd like to ask that you also add the command line parameter to the alternative help output, which is printed by executing
  certutil -H -N

That's done in function LuN()

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 825817 [details] [diff] [review]
Patch: add a "--empty-password" option to set the empty password non-interactively when creating cert database using -N command

r- because I proposed an enhancement for completeness

Comment 5

[Kai Engert (:KaiE:)]

Note, attaching the changes to the .html and the .1 file isn't necessary, because they are generated automatically. Attaching the changes to the .xml input file is sufficient.

Comment 6

[Eric Wong]

Attachment: certutil_empty_password.diff

Comment 7

[Eric Wong]

(In reply to Kai Engert (:kaie) from comment #3)
> It's already possible to create a database with an empty password
> automatically, by using a password file that contains a newline only, e.g.
> as created using:
>   echo > password-file

Noted, thanks.

> I looked at your patch, and it seems correct to me. However, I'd like to ask
> that you also add the command line parameter to the alternative help output,
> which is printed by executing
>   certutil -H -N
> 
> That's done in function LuN()

I think I have implemented this in my patch, do I misunderstand what you are saying?

# certutil -N -H
-N              Create a new certificate database
   -d certdir        Cert database directory (default is ~/.netscape)
   -P dbprefix       Cert & Key database prefix
   --empty-password  use empty password when creating a new database
#

Anyway, I have attached a new patch, please review, thanks!

Comment 8

[Kai Engert (:KaiE:)]

(In reply to Eric Wong from comment #7)
> I think I have implemented this in my patch, do I misunderstand what you are
> saying?

You are right, somehow I didn't see it earlier, sorry!

I suggest that you create/edit file ~/.hgrc on your system, and configure hg to produce more readable diffs. You could add the following section. After that, your patch will include the names of the function that is related to each chunk.

[diff]
git = 1
showfunc = 1
unified = 8

Comment 9

[Kai Engert (:KaiE:)]

Comment on attachment 827223 [details] [diff] [review]
certutil_empty_password.diff

r=kaie

Comment 10

[Kai Engert (:KaiE:)]

checked in:
https://hg.mozilla.org/projects/nss/rev/0560a4f7312a

Thanks for your contribution, Eric!

Comment 11

[Eric Wong]

(In reply to Kai Engert (:kaie) from comment #8)
> 
> I suggest that you create/edit file ~/.hgrc on your system, and configure hg
> to produce more readable diffs. You could add the following section. After
> that, your patch will include the names of the function that is related to
> each chunk.
> 
> [diff]
> git = 1
> showfunc = 1
> unified = 8

OK, got it!

Comment 12

[Eric Wong]

(In reply to Kai Engert (:kaie) from comment #10)
> checked in:
> https://hg.mozilla.org/projects/nss/rev/0560a4f7312a

Thanks for reviewing the patch!

Comment 13

[Kai Engert (:KaiE:)]

changing target milestone to 3.15.4