Android WebRTC deletes a shared GlobalRef

RESOLVED FIXED in Firefox 28

Status

()

Core
WebRTC
--
major
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gcp, Assigned: gcp)

Tracking

(Blocks: 1 bug)

Trunk
mozilla28
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox26 affected, firefox27 affected, firefox28 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Bug 918372 moved the Android WebRTC code over to maintaining a single, application-level, shared global Context reference. Part of the reason was to remove the need to attach/detach the JVM for the sole purpose of deleting one global references on each WebRTC session start.

Unfortunately the patch that removed the DeleteGlobalRef call:
https://hg.mozilla.org/releases/mozilla-aurora/rev/c8abbbef2a67

missed an instance in EnumerateAudioDevices.
(Assignee)

Comment 1

4 years ago
Created attachment 825835 [details] [diff] [review]
Patch 1. Fix leftover DeleteGlobalRef
Assignee: nobody → gpascutto
Attachment #825835 - Flags: review?(rjesup)
(Assignee)

Updated

4 years ago
status-firefox26: --- → affected
status-firefox27: --- → affected
status-firefox28: --- → affected
(Assignee)

Updated

4 years ago
Blocks: 918953
(Assignee)

Comment 2

4 years ago
The impact of this has so far been zero because:

a) http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_device/android/org/webrtc/voiceengine/WebRTCAudioDevice.java#l169

The reference is only used to get the System Audio Service (and that ref is kept).

b) Bug 918953
(Assignee)

Updated

4 years ago
Attachment #825835 - Flags: review?(rjesup) → review?(blassey.bugs)
Attachment #825835 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 3

4 years ago
http://hg.mozilla.org/mozilla-central/rev/d0e8a46aad5f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
status-firefox28: affected → fixed
You need to log in before you can comment on or make changes to this bug.