933730 - "ASSERTION: Appshell already destroyed?" due to making OfflineAudioContext in a dying Window

Status: NEW

(Core :: Web Audio, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase

1. Load the testcase
2. Click the button
3. Quit Firefox

Result: assertion during shutdown, and leak

###!!! ASSERTION: Appshell already destroyed?: 'Error', file content/media/MediaStreamGraph.cpp, line 1538

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Jesse Ruderman]

Attachment: leak info

Comment 3

[Maire Reavy [:mreavy]]

Karl -- Can I give this bug to you?  I know I've been giving a lot to you in the last week; so if you need me to find someone else for this one, just let me know.  Thanks!

Comment 4

[Karl Tomlinson (:karlt)]

Jesse, let me know if this or other bugs are blocking you, and I'll change priorities.

Comment 5

[Jesse Ruderman]

For this bug, I'm having my fuzzer ignore the assertion, and ignore leaks when the assertion occurs.  So I don't think it's blocking much.

Comment 6

[Karl Tomlinson (:karlt)]

When nsCycleCollector_shutdown() is called, nsThreadManager has already
shutdown all nsThreads.  StartNonRealtimeProcessing() won't get the new
nsThread that it expects.

I wonder whether we can get DestroyNonRealtimeInstance to destroy the graph
without creating the thread, by starting the graph at
LIFECYCLE_WAITING_FOR_MAIN_THREAD_CLEANUP.

But it also sounds like AudioContext shutdown is happening too early.
I wonder whether that could be delayed until after we know there is no script running.

Comment 7

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.