Closed
Bug 933731
Opened 11 years ago
Closed 11 years ago
Should construct panel before adding listener
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [Australis:P4][Australis:M9])
Attachments
(1 file)
|
2.55 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Add a console log to _removePanelCustomizationPlaceholders 2. Open customize mode from the toolbar, or using session restore, or any other way that means the panel isn't yet initialized ER: It gets called once because _showPanelCustomizationPlaceholders calls it AR: It gets called 2N times, for N items in the menupanel. Once to hide, once to reshow after the node has been added (which calls into hide again for good measure). (Found when working on bug 919965)
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #825887 -
Flags: review?(mconley)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 825887 [details] [diff] [review] Should construct panel before starting customize mode Review of attachment 825887 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this is a good idea. Thanks Gijs. :)
Attachment #825887 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/projects/ux/rev/5c36e40251b2
Whiteboard: [Australis:P4] → [Australis:P4][Australis:M9][fixed-in-ux]
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5c36e40251b2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][Australis:M9][fixed-in-ux] → [Australis:P4][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•