933748 - Rip out MetroInput support for pinch and rotate simple gestures

Status: RESOLVED FIXED

(Core Graveyard :: Widget: WinRT, defect)

Description

[Jim Mathies [:jimm]]

Pinch is handled by the apz, and we currently don't use rotate for anything. If we want we could keep rotate in the off chance we found a use for it.

Comment 1

[Jim Mathies [:jimm]]

Looks the simple fix is just disable the two options - 
http://mxr.mozilla.org/mozilla-central/source/widget/windows/winrt/MetroInput.cpp#1366

GestureSettings_ManipulationScale
GestureSettings_ManipulationRotate

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 825939 [details]
fix

argh, munged patch queue

Comment 4

[Jim Mathies [:jimm]]

Attachment: fix

Comment 5

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 825941 [details] [diff] [review]
fix

Review of attachment 825941 [details] [diff] [review]:
-----------------------------------------------------------------

Yaaaaaaay!

::: widget/windows/winrt/MetroInput.h
@@ +129,5 @@
>                                  IEdgeGestureEventArgs* aArgs);
>    HRESULT OnEdgeGestureCompleted(IEdgeGesture* aSender,
>                                   IEdgeGestureEventArgs* aArgs);
>  
> +  // Swipe gesture callback from the GestureRecognizer. 

Trailing whitespace!

@@ +134,4 @@
>    HRESULT OnManipulationCompleted(IGestureRecognizer* aSender,
>                                    IManipulationCompletedEventArgs* aArgs);
> +
> +  // Tap gesture callback from the GestureRecognizer. 

Trailing whitespace!

Comment 6

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/fx-team/rev/1a01ab0e0f8f

Comment 7

[Jim Mathies [:jimm]]

https://hg.mozilla.org/mozilla-central/rev/1a01ab0e0f8f

Comment 8

[Jim Mathies [:jimm]]

Follow up landing to remove those two LogFunction calls. Somehow the patch I landed lost those.

https://hg.mozilla.org/integration/fx-team/rev/bc80affb084e

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bc80affb084e