933779 - mach build * is broken on Windows

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Jim Mathies [:jimm]]

From tip this morning, I'm getting:

Jim@MONOLITH /T/Mozilla/mc
$ MOZCONFIG=/T/Mozilla/mcfgrel mach build binaries
 0:00.28 T:/mozilla-build/msys/bin/sh.exe -c T:/mozilla-build/msys/bin/mozmake.EXE -C t:\Mozilla\MC-REL -j4 -s backend.RecursiveMakeBackend
 0:00.29 mozmake.EXE: *** t:MozillaMC-REL: No such file or directory.  Stop.
Error running mach:

    ['build', 'binaries']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Process executed with non-0 exit code: [u'T:/mozilla-build/msys/bin/sh.exe', u'-c', u'T:/mozilla-build/msys/bin/mozmake.EXE -C t:\\Mozilla\\MC-REL -j4 -s backend.Recursi
veMakeBackend']

  File "t:\Mozilla\mc\python/mozbuild/mozbuild/mach_commands.py", line 366, in build
    log=False, print_directory=False)
  File "t:\Mozilla\mc\python/mozbuild\mozbuild\base.py", line 463, in _run_make
    return fn(**params)
  File "t:\Mozilla\mc\python/mozbuild\mozbuild\base.py", line 494, in _run_command_in_objdir
    return self.run_process(cwd=self.topobjdir, **args)
  File "t:\Mozilla\mc\python/mach\mach\mixin\process.py", line 137, in run_process
    raise Exception('Process executed with non-0 exit code: %s' % args)

Comment 1

[Jim Mathies [:jimm]]

mach build (folder) is also broken.

Comment 2

[Brandon Benvie [:benvie]]

This is happening with pymake as well.

Comment 3

[Brandon Benvie [:benvie]]

To be more specific, `mach build` works but `mach build (anything)` does not.

Comment 4

[Brandon Benvie [:benvie]]

I've traced the problem to https://hg.mozilla.org/integration/fx-team/rev/9d0bf12c1d1d (bug 877308).

Comment 5

[Mike Hommey [:glandium]]

Attachment: Always use forward slash as path separator when passing -C argument to make

This should fix it.

Comment 7

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 826168 [details] [diff] [review]
Always use forward slash as path separator when passing -C argument to make

Review of attachment 826168 [details] [diff] [review]:
-----------------------------------------------------------------

Applying this patch seems to have fixed my build.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 826168 [details] [diff] [review]
Always use forward slash as path separator when passing -C argument to make

This also fixed the problem for me.

Comment 10

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6379c1cb6fa7

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6379c1cb6fa7

Comment 12

[Ioana (away)]

Unfortunately, I can't set up the environment to test this on my Win7 machines - I keep getting error S1023 from the Ms DirectX installer even after removing everything C++ related (including registry entries).

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

This is working, no extra need to verify this.