933815 - Keep a marketplace load smoke test in the main repo

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

There was a regression last week in loading the Marketplace app. It crashed as soon as it was loaded.

We want to remove the marketplace tests into their own repo but we should retain a basic Marketplace smoketest so that the app loading does not regress again.

Test case:
1. Load firefox os
2. Switch into Homescreen
3. Navigate to homescreen panel that contains the Marketplace icon
4. tap the icon
5. Wait for self.apps.displayed_app.name == 'Marketplace'
6. Assert that the marketplace splash screen/loading screen clears and that Marketplace is loaded.

Add the test into the manifest.ini file and enable it for desktopb2g and device.

Comment 1

[Karan Singh]

Attachment: 0001-Bug-933815-933817-removed-marketplace-tests-added-ma.patch

Hey,

I've removed the existing marketplace tests, added a smoke test, and updated the manifest file. Check it out and let me know if you need anything changed.

Cheers,

Comment 2

[Zac C (:zac)]

Can you do this in two separate patches (pull requests?)

First do marketplace_launch, then removal of everything else.

When we do it as a Git pull we run it through Travis on the CI, too which is important for it being approved.

Comment 3

[Karan Singh]

Attachment: Pull Request

Added the smoke test and updated the manifest file.

Comment 5

[Zac C (:zac)]

Comment on attachment 826906 [details] [review]
Pull Request

Comments are in the pull request!

Comment 6

[Zac C (:zac)]

Karan, are you still able to work on this?

Otherwise I'll re-assign it.

Comment 7

[Zac C (:zac)]

Comment on attachment 826906 [details] [review]
Pull Request

I know this works OK because I ran it yesterday :P 
One tiny little nit-pick on the order of the include. In addition to that, all of the commits need to be squashed into 1 so that we can move it across branches.

After that we are ready to go! r? me again when it's done :)

Comment 8

[Zac C (:zac)]

PS for anyone else reviewing this: we thought it would be easier to leave the few locators inline so as to not need a Marketplace app object at all, considering that the scope of this test is so small and it will be the only Marketplace test in the main repo.

Comment 9

[Karan Singh]

Comment on attachment 826906 [details] [review]
Pull Request

Hey,

I squashed all my commits and ordered the manifest correctly.
The second last commit was the squash, I'm not sure whats up with the last merge, let me know if it looks alright. 

https://github.com/mozilla-b2g/gaia/pull/13357/commits

Thanks!

Comment 10

[Zac C (:zac)]

That doesn't look right - they should all be squashed into just one commit. Not sure what you've done there!

Comment 11

[Karan Singh]

Attachment: Pull Request

I closed my previous Pull Request and made a new one since it seemed simpler. Sorry I'm still getting used to the the git workflow.

Thanks for your time,

Comment 12

[Zac C (:zac)]

Comment on attachment 8334098 [details] [review]
Pull Request

r+ thanks Karan!

Comment 13

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/97c9b1deff913ea9e179d3d8c0a4f8b89017f994

Comment 14

[Zac C (:zac)]

This would fit in on v1.2, but with a little bit of duplication between marketplace-tests-gaia.

Comment 15

[[:AndreiH]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13901

Pointer to Github pull-request

Comment 16

[[:AndreiH]]

Comment on attachment 8335996 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13901

Uplifted to v1.2

Comment 17

[Trif Andrei-Alin[:AlinT]]

Merged in v1.2:
https://github.com/mozilla-b2g/gaia/commit/34022d1bab6984ec258de7cfed6b8fe716570d78
marking this as resolved fixed