Closed
Bug 933817
Opened 11 years ago
Closed 11 years ago
Remove all marketplace tests from master
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-v1.2 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | affected |
People
(Reporter: zcampbell, Assigned: karan.basi)
References
Details
Attachments
(2 files, 1 obsolete file)
We have moved the marketplace tests out into their own repo. The ones in this repo are now out of date and should be removed. This task is to remove the parts of the tests and app objects BUT retain the smoke test as detailed in bug 933815.
Assignee | ||
Comment 1•11 years ago
|
||
(same as Bug 933815 comment) Hey, I've removed the existing marketplace tests, added a smoke test, and updated the manifest file. Check it out and let me know if you need anything changed. Cheers,
Attachment #826528 -
Flags: review?(zcampbell)
Reporter | ||
Comment 2•11 years ago
|
||
We also need to remove everything that is not used by `test_marketplace_launch` in the apps/marketplace/ folder.
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 4•11 years ago
|
||
I intentionally wanted these as separate pull requests so I left them as separate bugs(tasks) too!
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: DUPLICATE → ---
Comment 5•11 years ago
|
||
Sorry Zac! Overzealous.
Reporter | ||
Comment 6•11 years ago
|
||
Hey Karan, you can finish this pull now as I've just merged bug 933815. I think your patch will need to be changed a bit as we can get rid of the marketplace app object entirely. But push it straight as a Git PR so we can be sure it does not regress anything :)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 7•11 years ago
|
||
Removed all marketplace tests (Exlcuding the smoketest from Bug 933815) and all unused app objects.
Attachment #826528 -
Attachment is obsolete: true
Attachment #826528 -
Flags: review?(zcampbell)
Attachment #8334615 -
Flags: review?(zcampbell)
Reporter | ||
Comment 8•11 years ago
|
||
Comment on attachment 8334615 [details] [review] Pull Request I found one more bit that needs to be removed: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L593 Sorry for not noticing it earlier! It was a method used by the old tests during the setUp to install the app. We definitely don't need it anymore.
Attachment #8334615 -
Flags: review?(zcampbell) → review-
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 8334615 [details] [review] Pull Request Good catch, I tried searching the folder for all marketplace text but I must have missed this file. I removed the function and updated the PR. Thanks,
Attachment #8334615 -
Flags: review- → review?(zcampbell)
Reporter | ||
Comment 10•11 years ago
|
||
Comment on attachment 8334615 [details] [review] Pull Request It's perfect! r+! Thanks Karan!
Attachment #8334615 -
Flags: review?(zcampbell) → review+
Reporter | ||
Comment 11•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/7e7e6841c16993ee37f3f7c849754e3f1d301e2c Let's do this on v1.2 aswell!
status-b2g-v1.2:
--- → affected
Comment 12•11 years ago
|
||
Pointer to Github pull-request
Comment 13•11 years ago
|
||
Comment on attachment 8335999 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13902 Uplifted to v1.2
Attachment #8335999 -
Flags: review?(trifandreialin)
Attachment #8335999 -
Flags: review?(moz.teodosia)
Attachment #8335999 -
Flags: review?(florin.strugariu)
Attachment #8335999 -
Flags: review?(bob.silverberg)
Updated•11 years ago
|
Attachment #8335999 -
Flags: review?(trifandreialin)
Attachment #8335999 -
Flags: review+
Comment 14•11 years ago
|
||
Comment on attachment 8335999 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13902 See comments in the PR.
Attachment #8335999 -
Flags: review?(bob.silverberg) → review-
Comment 15•11 years ago
|
||
Comment on attachment 8335999 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13902 looks good in combination with Bug 933815 - Keep a marketplace load smoke test in the main repo
Attachment #8335999 -
Flags: review?(florin.strugariu) → review+
Comment 16•11 years ago
|
||
done in v1.2 as well!!: https://github.com/mozilla-b2g/gaia/commit/e4a61b38c9ae0c4871613eb355081bfb5b387d84
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•