Closed Bug 933909 Opened 11 years ago Closed 11 years ago

Remove more unused en-US pages from SVN

Categories

(www.mozilla.org :: Legacy PHP system, defect)

Product:
www.mozilla.org
Component:
Legacy PHP system
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sgarrity, Assigned: sgarrity)

Details

(Whiteboard: [kb=1173558] r=122575)

Attachments

(3 files, 1 obsolete file)

bug-933909-svn-removes.diff
85.38 KB, patch
pmac
: review+
Details | Diff | Splinter Review
List of empty directories to remove
2.54 KB, text/plain
pmac
: review+
Details
bug-933909-svn-moreremoves2.diff
278.71 KB, patch
pmac
: review+
Details | Diff | Splinter Review
A bug for me to track more unused en-US pages that can be safely removed from SVN. So far: /en-US/about/partnerships.html /en-US/foundation/annualreport/2010 (note that other locales still exist for these pages in PHP, but are not accessible due to redirects. See Bug 925564 for details.
Looks like everything in */newsletter/ can go to.
Pascal, it looks to me like everything in /xx-XX/newsletter/ can be removed for all but en-US. The en-US files will need closer review. Can you confirm?
Flags: needinfo?(pascalc)
I didn't work on the migration to Bedrock myself as most of it happened while I was on PTO this summer but yes I think it can be removed, let's ask for confirmation to Jessilyn first
Flags: needinfo?(pascalc) → needinfo?(jdavis)
Hi Steven- I've got notes on the files in the newsletter folder starting at line 2182 of the spreadsheet. https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0Algxlsc2cLlldE9fMWVxN2UtdU80a3MzTzVaekgtOWc#gid=0 Most of it is ready to delete, but I need to file a bug to get Hacks migrated and Jess needs to follow up on a couple of others. Thx, Jen
I synced up with Jen and she's following up with the Affiliates app tab for Facebook's sign up form. Otherwise, I think everything in the gdoc is up to date. Please don't delete anything that would stop the old php footer signup forms working on old l10n php pages that are still live. (ie https://www.mozilla.org/de/firefox/fx/ and https://www.mozilla.org/de/firefox/features/ etc.)
Flags: needinfo?(jdavis)
(In reply to Steven Garrity [:sgarrity] from comment #0) > /en-US/foundation/annualreport/2010 (note that other locales still exist for > these pages in PHP, but are not accessible due to redirects. This has been removed in Bug 925564.
Assignee: nobody → steven
Whiteboard: [kb=1173558]
patch to remove the following unused files from SVN: D en-US/about/partnerships.html D en-US/newsletter/2010-09 D en-US/newsletter/2010-09/index.html D en-US/newsletter/2010-09/source.html D en-US/newsletter/existing D en-US/newsletter/existing/index.html D en-US/newsletter/updated D en-US/newsletter/updated/index.html D en-US/newsletter/welcome D en-US/newsletter/welcome/index.html D en-US/newsletter/welcome/source.html D ko/about D ko/about/partnership.html
Attachment #828063 - Flags: review?(pmac)
Attachment #828063 - Flags: review?(pmac) → review+
Whiteboard: [kb=1173558] → [kb=1173558] r=122084
Applied to trunk in r122084. Merged to stage in r122085, production in r122086.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attached patch bug-933909-svn-moreremoves.diff (obsolete) — — Splinter Review
More SVN removes. This patch removes the following unused (as far as my searching can confirm) files: D ca/mobile/sms-thanks.html D cs/mobile/sms-thanks.html D csb/mobile/sms-thanks.html D de/mobile/sms-thanks.html D en-GB/mobile/sms-thanks.html D en-US/img/covehead D en-US/img/covehead/features D en-US/img/covehead/features/addons-mac.png D en-US/img/covehead/features/addons.png D en-US/img/covehead/features/anti-malware-mac.png D en-US/img/covehead/features/anti-malware.png D en-US/img/covehead/features/bookmarks-mac.png D en-US/img/covehead/features/bookmarks.png D en-US/img/covehead/features/download-manager-mac.png D en-US/img/covehead/features/download-manager.png D en-US/img/covehead/features/find-mac.png D en-US/img/covehead/features/find.png D en-US/img/covehead/features/help-mac.png D en-US/img/covehead/features/help.png D en-US/img/covehead/features/integrated-web-search-mac.png D en-US/img/covehead/features/integrated-web-search.png D en-US/img/covehead/features/location-bar-mac.png D en-US/img/covehead/features/location-bar.png D en-US/img/covehead/features/password-manager-mac.png D en-US/img/covehead/features/password-manager.png D en-US/img/covehead/features/performance-chart.png D en-US/img/covehead/features/search-suggestions-mac.png D en-US/img/covehead/features/search-suggestions.png D en-US/img/covehead/features/security-id-mac.png D en-US/img/covehead/features/security-id.png D en-US/img/covehead/features/smart-bookmarks-mac.png D en-US/img/covehead/features/smart-bookmarks.png D en-US/img/covehead/features/spell-checking.png D en-US/img/covehead/features/svn-commit.tmp D en-US/img/covehead/features/tabs-mac.png D en-US/img/covehead/features/tabs.png D en-US/img/newsletter D en-US/img/newsletter/studentreps D en-US/img/newsletter/studentreps/check.png D en-US/img/tignish D en-US/img/tignish/firstrun D en-US/img/tignish/firstrun/welcome-3-5.png D en-US/img/tignish/firstrun/welcome.png D en-US/img/tignish/whatsnew D en-US/img/tignish/whatsnew/sub-feature-personas.png D en-US/img/tignish/whatsnew/welcome-3-5.png D en-US/mobile/sms-thanks.html D es-AR/mobile/sms-thanks.html D es-ES/mobile/sms-thanks.html D eu/mobile/sms-thanks.html D fr/mobile/sms-thanks.html D fy-NL/mobile/sms-thanks.html D gl/mobile/sms-thanks.html D hu/mobile/sms-thanks.html D img/mobile/addons-puzzle-sm.png D img/mobile/beta D img/mobile/beta/beta-install-inset.png D img/mobile/beta/beta-itstime-tshirt.png D img/mobile/beta/connect-facebook.png D img/mobile/beta/connect-newsletter.png D img/mobile/beta/connect-survey.png D img/mobile/beta/connect-twitter.png D img/mobile/beta/facebook-icon.gif D img/mobile/beta/link-icon.png D img/mobile/beta/qr-code.png D img/mobile/beta/section-1.png D img/mobile/beta/section-2.png D img/mobile/beta/section-3.png D img/mobile/beta/social-bg-bottom.png D img/mobile/beta/social-bg.png D img/mobile/beta/sub-feature-background.png D img/mobile/beta/twitter-icon.png D img/mobile/beta/video-thumb-lg.png D img/mobile/beta/video-thumb.png D img/mobile/img D img/mobile/m D img/mobile/m/nav-arrow.png D img/mobile/send-button.png D img/mobile/synchronize-divider.png D img/mobile/synchronize-feature-background.png D img/mobile/synchronize-sidebar-background.png D img/mobile/weave-background.png D img/tignish/firstrun D img/tignish/firstrun/customize-bottom.png D img/tignish/firstrun/link-arrow-rtl.png D img/tignish/firstrun/link-arrow.png D img/tignish/firstrun/personalize-bottom.png D img/tignish/firstrun/sub-feature-bottom.png D img/tignish/firstrun/sub-feature-top.png D includes/headers/mobile/sms-thanks.php D includes/messagemedia D includes/messagemedia/SmsInterface.inc D includes/mobile-beta-send-postcard.php D includes/mobile-sms-form.php D includes/mobile-sms.inc.php D it/mobile/sms-thanks.html D js/sms-form.js D lij/mobile/sms-thanks.html D lt/mobile/sms-thanks.html D nl/mobile/sms-thanks.html D pa-IN/mobile/sms-thanks.html D pl/mobile/sms-thanks.html D pt-BR/mobile/sms-thanks.html D pt-PT/mobile/sms-thanks.html D ru/mobile/sms-thanks.html D sk/mobile/sms-thanks.html D sq/mobile/sms-thanks.html D style/covehead/mobile-sms-thanks.css D style/mobile D style/tignish/mobile-later.css D vi/mobile/sms-thanks.html D zh-CN/mobile/sms-thanks.html D zh-TW/mobile/sms-thanks.html
Attachment #828229 - Flags: review?(pmac)
Attachment #828229 - Flags: feedback?(pascalc)
pmac, I've also got a list of 127 empty directories in SVN that I'd like to remove. SVN gets confused trying to diff empty dirs, so here's a plain text list of dirs I'd like to 'svn rm'.
Attachment #828233 - Flags: review?(pmac)
Comment on attachment 828229 [details] [diff] [review] bug-933909-svn-moreremoves.diff Review of attachment 828229 [details] [diff] [review]: ----------------------------------------------------------------- Please keep this file: img/mobile/m/nav-arrow.png It is still used in an include for locales for the firstrun page and this page will be replaced by a new one on Bedrock for locales this quarter?
Attachment #828229 - Flags: feedback?(pascalc)
Updated patch that leaves the img/mobile/m/nav-arrow.png image in place (thanks Pascal).
Attachment #828229 - Attachment is obsolete: true
Attachment #828229 - Flags: review?(pmac)
Attachment #828707 - Flags: review?(pmac)
Attachment #828707 - Flags: feedback?(pascalc)
beta-install-inset.png Still used in channel.lang. We're far from being done with the move to bedrock, so I think we need to keep it (e.g. bottom of this page http://www.mozilla.org/uk/firefox/channel/).
Whiteboard: [kb=1173558] r=122084 → [kb=1173558] r=122575
patch from comment #12 has been applied to trunk with flod's suggestions in r122575, merged to tags/stage in r122576, and merged to tags/production in r122577.
Removed the empty DIRs in trunk in r122578.
Merged empty-dir deletes to tags/stage in r122581 and tags/production in r122583.
Attachment #828233 - Flags: review?(pmac) → review+
Attachment #828707 - Flags: review?(pmac) → review+
Apparently I like to do my reviews after things land in prod :( Sorry for the delay :sgarrity.
Attachment #828707 - Flags: feedback?(pascalc)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: