933944 - rules.html has race condition

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Description

[[e-mail] (:bhearsum)]

Rail discovered this today when re-enabling Aurora updates. If you click "update" on one rule, and then "update" on another rule before the first update finishes, you will end up updating the second rule. This is because there's only one form for all of the existing rules, and clicking on "Update" sets the "rule_id" value of the form, which is read in the Javascript that does the update.

We may need to use a separate form for each rule, or perhaps just pass rule_id to submitRuleForm (rather than passing the ruleForm itself).

Comment 1

[[e-mail] (:bhearsum)]

Attachment: try to fix rules race

I wasn't able to reproduce this locally, but I'm pretty sure this should fix the problem...

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/244e39909785d1103977ac0ad650558885905225
bug 933944: rules.html has race condition. r=rail

Comment 3

[[e-mail] (:bhearsum)]

This patch is in production, and I wasn't able to repro the problem when I was testing against aus4-admin-dev. I'm pretty sure this is fixed...