Resolve memory leak in browser_dbg_clean-exit-window.js

NEW
Unassigned

Status

()

Firefox
Developer Tools: Debugger
P3
normal
4 years ago
3 years ago

People

(Reporter: bgrins, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [test disabled])

(Reporter)

Description

4 years ago
I have disabled this debugger test to get rid of our remaining b-c leaks.  We should either fix this test after tracing down the cause of the leak, or remove the test altogether.

As Panos says in Bug 932880 Comment 50:

> The last leaking test with ttaubert's patch from bug 932898 is browser_dbg_clean-exit-window.js. This patch contains some fixes and cleanups that unfortunately don't plug the leak. Unless someone can come up with any other ideas, I am of the opinion that once Tim's patch lands we should just disable this test.

> The test was created to make sure we don't regress the small fix in bug 916458, but I think I have spent a disproportionate amount of time on it compared to its significance. I will try to track down someone more knowledgable with leaks than me to look into it, but if it comes to block the landing of Tim's patch, then let's just disable it for now.

Updated

4 years ago
Depends on: 946641

Comment 1

4 years ago
I'm pretty sure this is case of window closing racing with unsuppressing event handling again. This should be fixed at a platform level.

Comment 2

4 years ago
I believe the patches for bug 946641 plugged one leak, but it's still leaking, but *only* when run locally as the only test. It doesn't leak when run as a part of the entire b-c suite.

Didn't have any luck debugging with CC logs or even refcount logs. Marking as [leave open].
Whiteboard: [leave open]
Priority: -- → P3
Is this bug still valid?  The only manifest entry I can find for this file is at http://mxr.mozilla.org/mozilla-central/source/browser/devtools/debugger/test/browser.ini#118, and that doesn't seem to disable it anywhere.
As comment 2 explains this test only leaks when run as a single test, not as art of the entire suite. I've edited the bug summary to clarify this.
Summary: Resolve memory leak in browser_dbg_clean-exit-window.js → Resolve memory leak in browser_dbg_clean-exit-window.js when run as a single test
Whiteboard: [leave open]
My patch in bug 805068 exposes this leak when the test runs as part of the entire suite.
Blocks: 805068

Updated

4 years ago
OS: Mac OS X → All
Hardware: x86 → All
(In reply to Dão Gottwald [:dao] from comment #5)
> My patch in bug 805068 exposes this leak when the test runs as part of the
> entire suite.

Test disabled in https://hg.mozilla.org/mozilla-central/rev/0c890d80e9a6.
No longer blocks: 805068
Depends on: 805068
Whiteboard: [test disabled]

Updated

4 years ago
Summary: Resolve memory leak in browser_dbg_clean-exit-window.js when run as a single test → Resolve memory leak in browser_dbg_clean-exit-window.js

Updated

3 years ago
Blocks: 1114553
You need to log in before you can comment on or make changes to this bug.