Trying to load an online support link from the Settings Help Menu loads a settings app error page

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jsmith, Assigned: gerard-majax)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 verified)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 826142 [details]
Screenshot

Build: 11/1 Buri 1.2 Build

STR

1. Setup your build according to https://wiki.mozilla.org/B2G/QA/Customizations#Build_Setup with a AT&T SIM included
2. Go to settings --> help
3. Select the online support link

Expected

The URL at the online support link should load.

Actual

A browser error page is reported - see screenshot.
(Reporter)

Updated

5 years ago
Blocks: 891724
blocking-b2g: --- → koi?
Whiteboard: [systemsfe]
Users are impacted by not being able to see a help page. This also breaks SIM customization.
blocking-b2g: koi? → koi+
(Assignee)

Comment 2

5 years ago
I'm looking into this.
Assignee: nobody → lissyx+mozillians
(Assignee)

Comment 3

5 years ago
Dumb question, what is the expected UX when we have no network ?
(Reporter)

Comment 4

5 years ago
(In reply to Alexandre LISSY :gerard-majax from comment #3)
> Dumb question, what is the expected UX when we have no network ?

If you are within an app, it should display an offline error modal dialog that states that there is no network connection. On the modal dialog, a user is allowed to cancel or try again.
(Assignee)

Comment 5

5 years ago
The AT&T support website is Youtube ?
(Assignee)

Comment 6

5 years ago
(In reply to Jason Smith [:jsmith] from comment #4)
> (In reply to Alexandre LISSY :gerard-majax from comment #3)
> > Dumb question, what is the expected UX when we have no network ?
> 
> If you are within an app, it should display an offline error modal dialog
> that states that there is no network connection. On the modal dialog, a user
> is allowed to cancel or try again.

So, if the user has no network connection when tapping on the support link, we should have this modal dialog error ?
(Reporter)

Comment 7

5 years ago
(In reply to Alexandre LISSY :gerard-majax from comment #5)
> The AT&T support website is Youtube ?

That's just my test URL I'm using to test customizations out. I was using google.com & youtube.com as test URLs to test this feature.
(Assignee)

Comment 8

5 years ago
Okay, I actually do reproduce the issue.
(Reporter)

Comment 9

5 years ago
(In reply to Alexandre LISSY :gerard-majax from comment #6)
> (In reply to Jason Smith [:jsmith] from comment #4)
> > (In reply to Alexandre LISSY :gerard-majax from comment #3)
> > > Dumb question, what is the expected UX when we have no network ?
> > 
> > If you are within an app, it should display an offline error modal dialog
> > that states that there is no network connection. On the modal dialog, a user
> > is allowed to cancel or try again.
> 
> So, if the user has no network connection when tapping on the support link,
> we should have this modal dialog error ?

Yes. Although in this bug's case, there was an internet connection, so we should have opened the browser with the target online support link.
(Assignee)

Comment 10

5 years ago
(In reply to Jason Smith [:jsmith] from comment #9)
> (In reply to Alexandre LISSY :gerard-majax from comment #6)
> > (In reply to Jason Smith [:jsmith] from comment #4)
> > > (In reply to Alexandre LISSY :gerard-majax from comment #3)
> > > > Dumb question, what is the expected UX when we have no network ?
> > > 
> > > If you are within an app, it should display an offline error modal dialog
> > > that states that there is no network connection. On the modal dialog, a user
> > > is allowed to cancel or try again.
> > 
> > So, if the user has no network connection when tapping on the support link,
> > we should have this modal dialog error ?
> 
> Yes. Although in this bug's case, there was an internet connection, so we
> should have opened the browser with the target online support link.

Yep. I think I located the issue: when we do the request to get the support.onlinesupport.href value, we add a onsuccess callback, but inside this callback we access ['support.onlinesupport.href'] in the requets object instead of the .result object.
(Assignee)

Comment 11

5 years ago
Okay so I think we have another bug here, when we have no network connection. I'll open a follow up.
(Assignee)

Comment 12

5 years ago
Created attachment 828265 [details] [review]
Link

Please find attached a link to the github pull request
Attachment #828265 - Flags: review?(aus)

Comment 13

5 years ago
Comment on attachment 828265 [details] [review]
Link

Looks good!
Attachment #828265 - Flags: review?(aus) → review+
(Assignee)

Comment 14

5 years ago
https://github.com/mozilla-b2g/gaia/commit/df92f0ebd89efbc63570a61e70c4304c17b8b555
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Keywords: verifyme
QA Contact: jsmith
Uplifted df92f0ebd89efbc63570a61e70c4304c17b8b555 to:
v1.2: de60d333a3056d098ec5159a81c212f28b3e6a6c
status-b2g-v1.2: --- → fixed
(Reporter)

Comment 16

5 years ago
lgtm on 1.2
status-b2g-v1.2: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.