Closed Bug 934001 Opened 6 years ago Closed 6 years ago
View's set Image Bitmap is evil
Calling setImageBitmap(null) creates BitmapDrawables, BitmapDrawable$State, and associated Paint objects. That's so much memory for not showing anything! :O
Feels so light.
Attachment #826153 - Flags: review?(mark.finkle)
Comment on attachment 826153 [details] [diff] [review] Patch We should find a way to get this kind of code change documented so other people remember it. Maybe a simple post to mobile-dev-firefox? Just a short paragraph on why setImageBitmap(null) is not as good as setImageDrawbale(null). I thought there was another issue with setImageBitmap(null)/setImageDrawable(null) too?
Attachment #826153 - Flags: review?(mark.finkle) → review+
I also found this tidbit: https://bugzilla.mozilla.org/show_bug.cgi?id=923218#c8
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Do we want to uplift this? Seems trivial.
Comment on attachment 826153 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Favicon refactor User impact if declined: Memory and jank issues Testing completed (on m-c, etc.): It's been on m-c for a while Risk to taking this patch (and alternatives if risky): low, low risk String or IDL/UUID changes made by this patch: none
Attachment #826153 - Flags: approval-mozilla-aurora?
Aurora is 28 as of today. Is this good enough to take for beta?
Comment on attachment 826153 [details] [diff] [review] Patch IMO, yes. Totally safe one-liner.
Attachment #826153 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Attachment #826153 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
rnewman landed this. https://hg.mozilla.org/releases/mozilla-beta/rev/10ecc8f4258e
You need to log in before you can comment on or make changes to this bug.