Closed
Bug 934035
Opened 11 years ago
Closed 11 years ago
Make PeerConnectionObserver's constructor not take an object argument
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.78 KB,
patch
|
jib
:
review+
|
Details | Diff | Splinter Review |
In Monday's DOM bindings meeting, somebody suggested a little trick: we can pass through the implementation object to the constructor as an Xray expando on an arbitrary object. I'm using PeerConnection for no particular reason. Maybe that's just confusing.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 826209 [details] [diff] [review] pass it around Review of attachment 826209 [details] [diff] [review]: ----------------------------------------------------------------- I should probably document this weirdness, but I'm not sure where.
Attachment #826209 -
Flags: review?(jib)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 826209 [details] [diff] [review] pass it around Review of attachment 826209 [details] [diff] [review]: ----------------------------------------------------------------- lgtm. Works, and I verified that _innerObject does not show up in web console, just for good measure. :-)
Attachment #826209 -
Flags: review?(jib) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1413b0652528
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1413b0652528
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•