Make PeerConnectionObserver's constructor not take an object argument

RESOLVED FIXED in mozilla28

Status

()

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Assignee

Description

6 years ago
In Monday's DOM bindings meeting, somebody suggested a little trick: we can pass through the implementation object to the constructor as an Xray expando on an arbitrary object.  I'm using PeerConnection for no particular reason.  Maybe that's just confusing.
Assignee

Comment 1

6 years ago
Assignee

Comment 2

6 years ago
Comment on attachment 826209 [details] [diff] [review]
pass it around

Review of attachment 826209 [details] [diff] [review]:
-----------------------------------------------------------------

I should probably document this weirdness, but I'm not sure where.
Attachment #826209 - Flags: review?(jib)
Comment on attachment 826209 [details] [diff] [review]
pass it around

Review of attachment 826209 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Works, and I verified that _innerObject does not show up in web console, just for good measure. :-)
Attachment #826209 - Flags: review?(jib) → review+
https://hg.mozilla.org/mozilla-central/rev/1413b0652528
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.