Closed Bug 934035 Opened 7 years ago Closed 7 years ago

Make PeerConnectionObserver's constructor not take an object argument

Categories

(Core :: WebRTC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

In Monday's DOM bindings meeting, somebody suggested a little trick: we can pass through the implementation object to the constructor as an Xray expando on an arbitrary object.  I'm using PeerConnection for no particular reason.  Maybe that's just confusing.
Attached patch pass it aroundSplinter Review
Comment on attachment 826209 [details] [diff] [review]
pass it around

Review of attachment 826209 [details] [diff] [review]:
-----------------------------------------------------------------

I should probably document this weirdness, but I'm not sure where.
Attachment #826209 - Flags: review?(jib)
Comment on attachment 826209 [details] [diff] [review]
pass it around

Review of attachment 826209 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Works, and I verified that _innerObject does not show up in web console, just for good measure. :-)
Attachment #826209 - Flags: review?(jib) → review+
https://hg.mozilla.org/mozilla-central/rev/1413b0652528
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.