934089 - Fix inconsistency ("Yahoo" vs "Yahoo!") in mobile/region.properties for Fennec

Status: RESOLVED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Francesco Lodolo [:flod]]

While reviewing another bug, I realized a problem with the current French setup (not part of bug 931109, problem is preexistent): searchplugin's description says "Yahoo!", region.properties just "Yahoo".

I'd prefer to wait for a reply in bug 903082 to understand if Yahoo is the right choice (they're currently using it in Fennec, not sure if that's just because of bug 335102). 

In my opinion the best solution would be to fix the .xml file, removing the exclamation mark.

Note that Firefox Desktop is correct, using "Yahoo" in both files.

Comment 1

[Francesco Lodolo [:flod]]

We got confirmation in bug 903082 comment 56 that "Yahoo" is fine. At this point we need to fix the .xml file to say just "Yahoo".

Comment 2

[Théo Chevalier]

Thanks Francesco, will provide a patch for review tomorrow

Comment 3

[Théo Chevalier]

Attachment: patch

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 827627 [details] [diff] [review]
patch

Review of attachment 827627 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks Théo.

Comment 5

[Théo Chevalier]

And pushed, thanks

http://hg.mozilla.org/l10n-central/fr/rev/ddf4c6c5b33e
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/ddf4c6c5b33e
http://hg.mozilla.org/releases/l10n/mozilla-beta/fr/rev/ddf4c6c5b33e