934098 - GCLI date type breaks when TZ changes

Status: RESOLVED INCOMPLETE

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Joe Walker [:jwalker]]

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_date.js | d2 time

Comment 1

[Joe Walker [:jwalker]]

Attachment: tz.patch

Comment 3

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/05c2644ab4ac
https://hg.mozilla.org/releases/mozilla-beta/rev/a607480b493c
https://hg.mozilla.org/mozilla-central/rev/3e17b9c2cd5a

Do we want to investigate fixing this test so DST doesn't break it?

Comment 4

[Joe Walker [:jwalker]]

(In reply to :Gijs Kruitbosch from comment #3)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/05c2644ab4ac
> https://hg.mozilla.org/releases/mozilla-beta/rev/a607480b493c
> https://hg.mozilla.org/mozilla-central/rev/3e17b9c2cd5a
> 
> Do we want to investigate fixing this test so DST doesn't break it?

Absolutely. https://github.com/joewalker/gcli/pull/17 is a start, it's a WIP that needs proper testing.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/a607480b493c

Comment 6

[Sebastian Zartner [:sebo]]

Joe, does this still need fixing?

Sebastian

Comment 7

[Joe Walker [:jwalker]]

This is still outstanding.
IIRC, I fixed the bug, but didn't re-enable the test(s) because the danger is that if the bug fix didn't work, then we wouldn't know until the next daylight savings change, when it would break the build. We need to check the bug fix more properly before re-enabling the test.

Comment 8

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Closing these as incomplete because component is going away. https://bugzilla.mozilla.org/show_bug.cgi?id=1491875