Closed Bug 934098 Opened 6 years ago Closed 1 year ago

GCLI date type breaks when TZ changes

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

defect
Not set

Tracking

(firefox26 disabled, firefox27 disabled, firefox28 disabled)

RESOLVED INCOMPLETE
Tracking Status
firefox26 --- disabled
firefox27 --- disabled
firefox28 --- disabled

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

(Whiteboard: [test disabled])

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/commandline/test/browser_gcli_date.js | d2 time
Attached patch tz.patchSplinter Review
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #826291 - Flags: review?(gijskruitbosch+bugs)
Attachment #826291 - Flags: review?(gijskruitbosch+bugs) → review+
Duplicate of this bug: 934096
Whiteboard: [test disabled]
(In reply to :Gijs Kruitbosch from comment #3)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/05c2644ab4ac
> https://hg.mozilla.org/releases/mozilla-beta/rev/a607480b493c
> https://hg.mozilla.org/mozilla-central/rev/3e17b9c2cd5a
> 
> Do we want to investigate fixing this test so DST doesn't break it?

Absolutely. https://github.com/joewalker/gcli/pull/17 is a start, it's a WIP that needs proper testing.
Joe, does this still need fixing?

Sebastian
Flags: needinfo?(jwalker)
This is still outstanding.
IIRC, I fixed the bug, but didn't re-enable the test(s) because the danger is that if the bug fix didn't work, then we wouldn't know until the next daylight savings change, when it would break the build. We need to check the bug fix more properly before re-enabling the test.
Flags: needinfo?(jwalker)
Product: Firefox → DevTools
Closing these as incomplete because component is going away. https://bugzilla.mozilla.org/show_bug.cgi?id=1491875
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.