93412 - memory leak of CERT tempCertDb and handle by NSS

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Jeff Hostetler]

The memory-based certificate database is not closed/deleted
resulting in a significant amount of memory being leaked.
also, the global CERTCertDBHandle used by nssinit to set the
default CERT db is never freed.

consider adding the following function to nss/lib/certdb/pcertdb.c:

void CERT_Shutdown(CERTCertDBHandle * handle)
{
    if ( handle->tempCertDB ) {
	certdb_Close(handle->tempCertDB);
	handle->tempCertDB = 0;
    }
}

and adding the following to nss/lib/nss/nssinit.c::NSS_Shutdown()

    certHandle = CERT_GetDefaultCertDB();
    if (certHandle)
+    {
    	CERT_ClosePermCertDB(certHandle);
+	CERT_Shutdown(certHandle);
+	PORT_Free(certHandle);
+    }
    CERT_SetDefaultCertDB(NULL);

Comment 1

[Wan-Teh Chang]

Assigned the bug to Bob.

Comment 2

[Keyser Sose]

Another patch.. Missed this one sorry..Thanks jeff..

Comment 3

[Robert Relyea]

Fixed in NSS 3.4

BTW, Jeff do you want your name added to the contributer's list in the NSS 
files that contain your patches (or patches derived from yours)?

bob