Touching gfx headers causes netwerk/ rebuild because of long sad #include chain

NEW
Unassigned

Status

()

Core
General
4 years ago
4 years ago

People

(Reporter: froydnj, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

+++ This bug was initially created as a clone of Bug #918651 +++

Here is a sad #include graph ( -> means #includes)

FTPChannelChild.cpp

 |
 |
 V

TabChild.h

 |
 |
 V

PBrowserChild.h

 |
 |
 V

PBrowser.h   -----------------> FrameMetrics.h

 |                                 |
 |                                 |
 V                                 V

gfxMatrix.h  --------------->  many other gfx things...



So there are various things that we can try to fix here, but apparently the first place to look (because it will affect a maximal number of .cpp files) is PBrowser.h which is a IPDL generated header.

We made it possible to forward-declare things in IPDL, but there are a fair number of gfx things (Units.h, etc.) that can't be forward-declared.  Those should be fixed up and the IPDL modified appropriately.
It looks like bug 904336 might take care of the TabChild.h badness.  There might be other include paths, though.
Depends on: 904336
You need to log in before you can comment on or make changes to this bug.