934169 - [Permission] Geolocalization dialog 'more info' link needs to change to 'hide info'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Adrian Custer]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131028225529

Steps to reproduce:

When a packaged app calls 
    navigator.geolocation.getCurrentPosition(...)
FFOS opens a permission dialog which has a 'More info...' link to get details. 

Clicking on the 'More info...' link provides more information but the link name stays the same.

However, since a second click on the link will hide the extra information, the link text should change to something like 'hide info' or 'less info' or some such.

This is happening on Firefox OS 1.1 (Uruguay distributed Alcatel One Touch Fire.) I will check the Simulator after submitting the bug (I need to restart FF for the update to work correctly it seems).


Actual results:

Clicking on the link called 'More info...' showed both more info and a link still called 'More info...'.



Expected results:

After the initial click on the 'More info...' link, the link name should change to a new name such as 'Hide info' or some such.

Comment 1

[Adrian Custer]

Confirmed also on the Firefox 1.2 Simulator run by the App Manager.

Comment 2

[Adrian Custer]

Firefox 1.3 Simulator on the App Manager fails to execute the getCurrentPosition() call; it seems like a no-op so I can not confirm there.

Comment 3

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8394589 [details] [review]
Pull request

Hi, please try to have a test for the functionality you added. Thanks.

Comment 5

[Sherman Chen [:chens] (inactive)]

Merged to master, r=alive
https://github.com/mozilla-b2g/gaia/commit/18a0615e4aa939d8ed4504ca1463916e67e619a4

Comment 6

[Andrew Stole [:astole]]

Seeing this issue on Tarako v1.3

1.3 Environmental Variables:
Device: Tarako 1.3
BuildID: 20140415004002
Gaia: 44ff6248c28ff83b9ad1161847a176399f93d3bb
Gecko: 28aea220e338
Version: 28.1
Firmware Version: SP6821