93420 - gkconshared_s not found when compiling accessible

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Frederic Crozat]

While creating Mandrake package for mozilla 0.9.3, I've encounter a bustage in 
accessible/build

gkconshared_s was not found by ld but it was in dist/lib..

Following patch fixed the problem

Comment 1

[Frederic Crozat]

Attachment: Add missing path for static lib

Comment 2

[Matthias Versen [:Matti]]

marking NEW
Thanks for the Patch !

Comment 3

[cls]

Why are we not seeing this bustage on the trunk?  What changed on the 0.9.3
branch?

Comment 4

[Frederic Crozat]

It doesn't different between trunk and 0.9.3 branch but I'm unable to compile
Mozilla 0.9.3 without this fix.. This might be a compiler dependent problem (we
are using gcc 2.96-95 in Mandrake cooker)

I think landing the move of -l$(DIST)/lib/libgkconshared_s.$(LIB_SUFFIX)
in SHARED_LIBRARY_LIBS to -lgkconshared_s (ie without explicit path to find lib)
in EXTRA_DSO_LIBS broke our build..

 

Comment 5

[Jon Granrose]

so is this a branch-only problem, or 0.9.3 and trunk?

If this is only on the 0.9.3 branch are we going to allow the checkin and retag
the files?

Comment 6

[Daniel (Leaf) Nunes]

we certainly didn't have any build bustage for the 0.9.3 release builds, but
it's possible that frederic is right about the compiler being the problem.

I'm not sure it's worth retagging 0.9.3, but it's worth getting into the trunk
if it fixes his compiler; Frederic, you can, if you need, make a branch based on
the 0.9.3 release tag for the mandrake distro.

Comment 7

[cls]

Ok, I see the problem.  In the main build, -L$(MOZ_BUILD_ROOT)/dist/lib is added
to the compile line by `nspr-config --libs` .  I'm guessing that Frederic is
building with a system installed version of nspr.  r=cls on the patch.

Comment 8

[Frederic Crozat]

You got it Christopher, I forgot to tell we are building with a separated nspr4
(extracted from Mozilla 0.9.3), since some new applications are beginning
to use it (ie Evolution ..)

Comment 9

[cls]

Patch has been checked in.