934233 - On certain pages APZController::IsTab fails to identify a tab document

Status: VERIFIED FIXED

(Core Graveyard :: Widget: WinRT, defect)

Description

[Jim Mathies [:jimm]]

On www.techmeme.com we fail to identify a top level tab for scrolling. Looks like the IsTab test needs some work.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

The problem is that ROOT_SCROLL_ID is a special case, and nsDOMWindowUtils->FindContentForViewId will just blindly return the root element in the window for it. Since the domwindowutils being used was for the XUL window, it would return the top-level element in the XUL window when the scrollId was ROOT_SCROLL_ID. Using nsLayoutUtils::FindContentFor returns the right answer instead because it does the proper map lookup. This also simplifies a bunch of the code.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 827456 [details] [diff] [review]
Patch

Been running with this for a while, definitely seems to fix tab detection.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/fx-team/rev/5298090cde0d

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5298090cde0d

Comment 5

[Manuela Muntean [Away]]

While scrolling www.techmeme.com on the Nightly from 2013-11-03 on Win 8.1 64-bit, I don't see any issue, I can see the same behavior as with Chrome.

Could you please give more details in order to reproduce this bug? Thanks!

Comment 6

[Jim Mathies [:jimm]]

I think we can safely mark this as verified.

Comment 7

[Manuela Muntean [Away]]

Considering that with Firefox 28 beta 6 I also don't see any issue while scrolling the site, and based on comment 5 and comment 6, I'm marking this verified as fixed.

Comment 8

[hecoplus]

I think we can safely mark this as verified.
https://deepotech.com/