Closed
Bug 934287
Opened 12 years ago
Closed 12 years ago
Add size and for data DrawTarget creation functions for Cairo
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: bas.schouten, Assigned: bas.schouten)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
4.41 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
We should add the size and for data DrawTarget creation function for cairo that have been on the Moz2D repo for a while to mozilla-central.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #826532 -
Flags: review?(matt.woodrow)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 826532 [details] [diff] [review]
Add size and for data DrawTargetCairo creation functions
Review of attachment 826532 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/DrawTargetCairo.cpp
@@ +1184,5 @@
> + aSize.width,
> + aSize.height,
> + aStride);
> + return InitAlreadyReferenced(surf, aSize);
> +}
This is probably ok for now, but we need some solution for deciding which cairo backend to actually use.
We probably still want to use x11 when its available at least.
Attachment #826532 -
Flags: review?(matt.woodrow) → review+
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•