Add checks to make sure the hidden window doesn't contain anything unexpected when browser is shutdown

NEW
Unassigned

Status

()

5 years ago
a year ago

People

(Reporter: smaug, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P2])

(Reporter)

Description

5 years ago
We should have some checks to ensure that whoever has used inner window also removes
the stuff from there. Inner window's document during shutdown should look like it looks
initially and window scope shouldn't have anything special either.
Whiteboard: [MemShrink]
Surely inner means hidden here ...?
(Reporter)

Comment 2

5 years ago
Yes, silly me.
Summary: Add checks to make sure inner window doesn't contain anything unexpected when browser is shutdown → Add checks to make sure the hidden window doesn't contain anything unexpected when browser is shutdown
Smaug, how difficult is this?  It doesn't sound too hard.

AIUI, this would overlap somewhat with the checking in bug 932898, but not entirely.
Whiteboard: [MemShrink] → [MemShrink:P2]
(In reply to Nicholas Nethercote [:njn] from comment #3)
> AIUI, this would overlap somewhat with the checking in bug 932898, but not
> entirely.

Yeah, any DOMWindows and DocShells left in the hiddenWindow would be detected by it.
(Reporter)

Comment 5

5 years ago
Some rather dummy check should be easy. Effectively store
document.documentElement.innerHTML somewhere and compare it to document.documentElement.innerHTML
when we're about to close and do something similar to properties in the window scope.
You need to log in before you can comment on or make changes to this bug.