Created attachment 826587 [details] [diff] [review] Fix standalone js's make install again, for aurora
Attachment #826587 - Flags: review?(mshal)
I'm a bit confused by this - where does EXPORTS_mozilla_FILES get defined? I tried to do a standalone js build so I could print out the value, but 'make install' is failing with: /home/marf/mozilla-central-git/js/src/mybuild/config/nsinstall -t mozjs-None.pc /home/marf/install-js/lib/pkgconfig /home/marf/mozilla-central-git/js/src/mybuild/_virtualenv/bin/python -m mozbuild.action.process_install_manifest --no-remove /home/marf/install-js/include/mozjs-None _build_manifests/install/dist_include From /home/marf/install-js/include/mozjs-None: Kept 86 existing; Added/updated 0; Removed 0 files and 0 directories. /home/marf/mozilla-central-git/js/src/mybuild/config/nsinstall -t /home/marf/install-js/include/mozjs-None/mozilla usage: /home/marf/mozilla-central-git/js/src/mybuild/config/nsinstall [-C cwd] [-L linkprefix] [-m mode] [-o owner] [-g group] [-DdltR] file [file ...] directory make: *** [install] Error 2 This is failing because EXPORTS_mozilla_FILES is still empty.
There might have been a change since aurora, then :( The patch was tested on aurora (where this needs fixing anyways).
Created attachment 827026 [details] [diff] [review] Fix standalone js's make install again So, indeed, bug 870401 changed things and the mfbt headers are now in the install manifest, so the custom rule to install them is now pointless (and broken, since EXPORT_mozilla is empty). The other patch is the variant necessary to fix the same bug on aurora. Please review both.
Attachment #827026 - Flags: review?(mshal)
Comment on attachment 826587 [details] [diff] [review] Fix standalone js's make install again, for aurora Makes sense - thanks for the details!
Attachment #826587 - Flags: review?(mshal) → review+
Attachment #826587 - Attachment description: Fix standalone js's make install again → Fix standalone js's make install again, for aurora
status-firefox26: --- → unaffected
status-firefox27: --- → affected
Comment on attachment 826587 [details] [diff] [review] Fix standalone js's make install again, for aurora [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 919832 User impact if declined: make install doesn't work for standalone js. Testing completed (on m-c, etc.): Tested on Debian packaging. Risk to taking this patch (and alternatives if risky): NPOTB for Firefox. Note the patch is not the same as the one landed on m-c because further changes since aurora merge have made the fix different. It's trivial enough, though. String or IDL/UUID changes made by this patch: None
Attachment #826587 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Attachment #826587 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox27: affected → fixed
status-firefox28: --- → fixed
You need to log in before you can comment on or make changes to this bug.