934335 - standalone js's make install broken again

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fix standalone js's make install again, for aurora

Comment 2

[Michael Shal [:mshal]]

I'm a bit confused by this - where does EXPORTS_mozilla_FILES get defined?

I tried to do a standalone js build so I could print out the value, but 'make install' is failing with:

/home/marf/mozilla-central-git/js/src/mybuild/config/nsinstall -t mozjs-None.pc /home/marf/install-js/lib/pkgconfig
/home/marf/mozilla-central-git/js/src/mybuild/_virtualenv/bin/python -m mozbuild.action.process_install_manifest --no-remove /home/marf/install-js/include/mozjs-None _build_manifests/install/dist_include
From /home/marf/install-js/include/mozjs-None: Kept 86 existing; Added/updated 0; Removed 0 files and 0 directories.
/home/marf/mozilla-central-git/js/src/mybuild/config/nsinstall -t  /home/marf/install-js/include/mozjs-None/mozilla
usage: /home/marf/mozilla-central-git/js/src/mybuild/config/nsinstall [-C cwd] [-L linkprefix] [-m mode] [-o owner] [-g group]
                                                                      [-DdltR] file [file ...] directory
make: *** [install] Error 2

This is failing because EXPORTS_mozilla_FILES is still empty.

Comment 3

[Mike Hommey [:glandium]]

There might have been a change since aurora, then :( The patch was tested on aurora (where this needs fixing anyways).

Comment 4

[Mike Hommey [:glandium]]

Attachment: Fix standalone js's make install again

So, indeed, bug 870401 changed things and the mfbt headers are now in the install manifest, so the custom rule to install them is now pointless (and broken, since EXPORT_mozilla is empty). The other patch is the variant necessary to fix the same bug on aurora. Please review both.

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 826587 [details] [diff] [review]
Fix standalone js's make install again, for aurora

Makes sense - thanks for the details!

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42e6d140004e

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 826587 [details] [diff] [review]
Fix standalone js's make install again, for aurora

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 919832
User impact if declined: make install doesn't work for standalone js.
Testing completed (on m-c, etc.): Tested on Debian packaging.
Risk to taking this patch (and alternatives if risky): NPOTB for Firefox. Note the patch is not the same as the one landed on m-c because further changes since aurora merge have made the fix different. It's trivial enough, though.
String or IDL/UUID changes made by this patch: None

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/42e6d140004e

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/05e8967817e7