934347 - New tabs opened via links from tabs with "Request desktop site" enabled should also have "Request desktop site" set

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement)

Description

[Steven Luo]

If you do the following (tested on the 2013-11-03 nightly as well as Firefox 25 stable on a Galaxy Nexus running Android 4.3):

1. Open a new tab
2. Enable "Request Desktop Site"
3. Visit any website which attempts to detect mobile browsers
4. Tap and hold on any link within the site, select "Open Link in New Tab"

you get a new tab without "request desktop site" enabled, which usually results in a mobile-formatted web page being shown.  It would be better if the new tab inherited the setting of "request desktop site" from the link's source tab -- this is what's done in recent releases of the built-in Android browser.

Comment 2

[Steven Luo]

Attachment: sample implementation

Comment 3

[Steven Luo]

Erm, this is not a duplicate of 790954 -- that bug is about always setting desktop mode by default, while I'm asking for this only in new tabs created via links from tabs which already have desktop mode set.

I've attached a patch against the trunk with a sample implementation of this feature -- that should at least give an idea of what I'm looking for.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Ian - What do you think about this idea?

Comment 5

[Ian Barlow (:ibarlow)]

This is one of those cases where some usage data would be really handy.

On the one hand, I can see the potential for a user wanting to be kept in more of a 
"desktop web" context for any site they link out to from a site that has RDS enabled. 

On the other hand, I also know that many users use RDS for *specific sites*, but not for everything on the web. For example, they might simply prefer the desktop version of the New York Times, but are happy to browse more mobile optimized experiences on other sites. 

I would love to know what is happening now with our current implementation. How many people are opening links in other tabs in RDS mode, and then *switching those tabs to RDS right away*? How many aren't? It would make this an easier decision. 

Right now I don't feel comfortable making the call one way or the other.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.