934366 - [B2G][Helix][Camera][shijinde]Camera filmstrip is hidden while previewing image

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Camera, defect, P2)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; aff-kingsoft-ciba; .NET4.0C; .NET4.0E; Zune 4.7; Tablet PC 2.0)

Steps to reproduce:

1、quickly press capture button and at least, you must capture five photos
2、quickly click filmstrip


Actual results:

1、the main screen shows the photo which you select from filmstrip.
2、the filmstrip shows preview photo about five seconds later.


Expected results:

1、the main screen shows the photo which you select from filmstrip.
2、the filmstrip shows photos.

Comment 1

[lecky]

Hi, wayne

I had found this bug and can reproduce everytime. you can see the attachment.

and I got some logs, if you quickly press capture button, and then quickly click filmstrip region,

so on the surface, you see the phone shows you select photo, actual the backgound will add image until the last one, and then will go to "hide" function, then the bug reproduces.

Comment 2

[lecky]

Attachment: log and screen.rar

Comment 3

[lecky]

Attachment: 934366_log_and_screen.zip

Comment 4

[Wayne Chang [:wchang]]

Following the STR I dont really see any problem on the device.

QAWANTED to check here.

Comment 5

[lecky]

Hi, this bug is very easy to reproduce.

I think you can reproduce in V1.2 if you never modify camera code.

Thanks

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

I can confirm this bug. But I think it is not so easy to reproduce. Some steps are so tricky.

The STR is:

1. open camera app
2. capture at least one picture
3. tap the screen to show the filmstrip. This is important to have a shown filmstrip.
4. press capture button and tap any image in the filmstrip immediately. This step needs to tap quickly. Well, if you take large picture, it doesn't need to do quickly.
5. wait 5 seconds and get the error. Camera app hide the filmstrip 5 seconds later after a picture is took.

We never found this kind of bug before. Maybe, it is a regression. QA, please help us to check if this is a regression.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

BTW, if we use slow storage device, this is easy to reproduce. The key is the time of writing image into storage. It is easy to reproduce on a slow microSD card. CPU speed doesn't make any difference.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: prevent timer requesting when preview is shown.

prevent to set hideTimer when previewing an image/video.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: video recording

I found another STR to reproduce the same symptom:

1. open camera app
2. take few pictures
3. tap screen to have filmstrip showed up.
4. switch to camcorder mode
5. tap image item in filmstrip and tap recording quickly, see attachment.

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 827872 [details] [review]
prevent timer requesting when preview is shown.

clear reviewing flag for finding better patch for both camera and camcorder cases.

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 827872 [details] [review]
prevent timer requesting when preview is shown.

Change the patch to have:
1. schedule auto hide of filmstrip when the preview is not shown
2. hide preview when someone hides filmstrip

Comment 12

[Matthew Vaughan]

This issue reproduces on the 11/7 1.1(Leo) and 1.2(Buri) builds. I followed STR from comment 6 and comment 9, both successfully reproducing this bug.

- 1.1 BUILD -
Environmental Variables:
Device: Leo v1.1 Mozilla RIL
BuildID: 20131107041203
Gaia: 39b0203fa9809052c8c4d4332fef03bbaf0426fc
Gecko: 31fa87bfba88
Version: 18.0

- 1.2 BUILD -
Environmental Variables:
Device: Buri v1.2 Mozilla RIL
BuildID: 20131107004003
Gaia: 590eb598aacf1e2136b2b6aca5c3124557a365ca
Gecko: 26f1e160e696
Version: 26.0

Comment 13

[Wayne Chang [:wchang]]

Checked the video in comment 9, looks to be small impact with uncommon STR.

Noming for v1.3 here.

Comment 14

[Beatriz Rodríguez [:brg]]

I do not know why you ni me here. But agree with comment 13.

Comment 15

[Hema Koka [:hema]]

Not marking this a blocker because of the uncommon STR but since John already has a fix, setting target milestone

Comment 17

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 827872 [details] [review]
prevent timer requesting when preview is shown.

According to offline discussion with Gnaneswar, he can reproduce the bug after this patch is applied. So, I clear the review flag and will do more tests on this patch.

Gnaneswar, if you have any idea about the patch, please feel free to upload yours.

Comment 18

[Gnaneswar]

John, after some more testing on nexus-4 with a full reinstall of gaia, it seems that issue is not reproducible with this patch.


Observed one point while testing multiple usecases.
Usecase: If we reverse the step 4 in comment 6 (i.e first tap the image from filmstrip and then capture the photo immediately), current behavior is that preview window is the final screen.

Should It be a view finder(because camera capture is the latest action)?

Comment 19

[Gnaneswar]

Attachment: Updated patch

It seems that below condition may not be required in the patch attached with comment 11

> +  if (isShown()) {

Attached updated patch.

Github PR: https://github.com/mozilla-b2g/gaia/pull/14643

Comment 20

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8347152 [details] [diff] [review]
Updated patch

Gnaneswer,

I don't have the right to review the Camera component. I will reset this to Diego. And please add more comments about the changes. Thanks.

Diego,

Gnaneswer is a contributor who is interesting on Camera. Please review his patch. Thanks.

Comment 21

[Gnaneswar]

(In reply to John Hu [:johnhu] from comment #20)
> Comment on attachment 8347152 [details] [diff] [review]
> Updated patch
 
>  And please add more comments about the changes.

This patch is the updated version of earlier submitted patch in comment 11.

1) It prevents timer requesting filmstrip hide if preview is shown.
2) It hides preview(only if preview is shown) if someone hides filmstrip.

3) Removed the redundant condition "to check if filmstrip is shown" (which was there in earlier patch) before fading the film strip after delay. Because hidePreivew() function would be called only when filmstrip is shown.

Above mentioned points in this patch would solve the comment 6 and 9 usecases respectively.

Comment 23

[Gnaneswar]

Requesting to let me know review comments of the patch.

Comment 24

[Diego Marcos [:dmarcos]]

Hi there. This patch has to be reviewed after the camera refactor that landed today. It shouldn't be too difficult. Do you want me to help?

Comment 25

[Diego Marcos [:dmarcos]]

Can you still reproduce this issue in the current gaia?

Comment 26

[John Hu [:johnhu][:johu][:醬糊小弟]]

Diego,

I can reproduce it with the new version of Camera.

Comment 27

[John Hu [:johnhu][:johu][:醬糊小弟]]

The STR in comment 9 is reproducible but not the comment 0.

Comment 28

[Gnaneswar]

Yes it is still reproducible on nexus-4.I checked with comment 6 steps

Comment 29

[Gnaneswar]

It seems that patch attached in comment 19 is still applicable. Please confirm

Comment 30

[Gnaneswar]

Diego,

Would like to know your comments.

Comment 31

[Diego Marcos [:dmarcos]]

We got rid of the filmstrip in camera. I close this bug