934409 - [fugu]The flash light state is not correct when enter and exit the camera app at recording mode

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Dafeng Xu]

Attachment: the patch of this bug

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22

Steps to reproduce:

1.open the camera app and switch to recording mode
2.turn on the flash light
3.press "Home" button and then re-entry the camera app
4.repeat the step '3' some times, you will find the flash light state is not correct


Actual results:

the flash light is turned off


Expected results:

the flash light should be turned on

Comment 1

[Dafeng Xu]

there are two reson of this bug:
   1.the camera.js dose not record the state of the flash light, the camera.patch resolve this problem
   2.in gecko, the flash light state is changed by multi-thread, sometimes the state is not correct, the GonkCameraControl.patch resolve this problem.

Comment 2

[James Zhang (Spreadtrum)]

Attachment: camera.js patch

Comment 3

[James Zhang (Spreadtrum)]

Attachment: GonkCameraControl.patch

Comment 4

[James Zhang (Spreadtrum)]

Hi Mchen,

   pls help to review dafeng's patch.

Comment 5

[Marco Chen [:mchen]]

Comment on attachment 826695 [details] [diff] [review]
GonkCameraControl.patch

Review of attachment 826695 [details] [diff] [review]:
-----------------------------------------------------------------

I am not the reviewer of camera module so transfer it to correct person.

Hi Mike,

Our partner of chip vendor found a issue related to flash light.
Could you help to give some suggestion? Thanks.

::: dom/camera/GonkCameraControl.cpp
@@ +522,4 @@
>     * require this so that changes take effect immediately before
>     * we can proceed.
>     */
> +#if 0

It seems that originally the designer didn't want "PushParametersImpl()" be performed on the main thread so dispatch it to camera thread. This can avoid any error inside camera service to block the main thread.

>> 2.in gecko, the flash light state is changed by multi-thread, sometimes the state is not correct, the 
>> GonkCameraControl.patch resolve this problem.

I didn't see "PushParametersImpl()" be performed by multi-threads but just camera thread only.

Comment 6

[Marco Chen [:mchen]]

Comment on attachment 826694 [details] [diff] [review]
camera.js patch

Review of attachment 826694 [details] [diff] [review]:
-----------------------------------------------------------------

Hi David,

Our partner of chip vendor found an issue about flash flight.
Could you help to give the feedback? Thanks.

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 826695 [details] [diff] [review]
GonkCameraControl.patch

We can't talk to the camera driver on the main thread, since it risks blocking the UI, which is unacceptable.

If you can explain why this fixes the flash issue, we can look at a better solution to it.

Comment 8

[James Zhang (Spreadtrum)]

(In reply to Mike Habicher [:mikeh] from comment #7)
> Comment on attachment 826695 [details] [diff] [review]
> GonkCameraControl.patch
> 
> We can't talk to the camera driver on the main thread, since it risks
> blocking the UI, which is unacceptable.
> 
> If you can explain why this fixes the flash issue, we can look at a better
> solution to it.

When re-entry the camera, gecko camera will first create new thread to set the default parameter, and it will create another thread to set the last exiting parameter.
Because two threads do RPC, and 'mParams' is not protected by mutex or semaphore. If one thread is reading mParams, another thread may change it, it cause this issue.

Comment 9

[James Zhang (Spreadtrum)]

Hi Mike,

    Dafeng will give you the log or backtrace of this issue.

Comment 10

[David Flanagan [:djf]]

Comment on attachment 826694 [details] [diff] [review]
camera.js patch

Review of attachment 826694 [details] [diff] [review]:
-----------------------------------------------------------------

The flash management code in camera.js is horrible.   

But the fix here isn't to make turnOffFlash() more complicated. The problem seems to be that we're changing the camera's internal state when we want to temporarily turn off the video light. turnOnFlash() is unused, so it can be deleted. What if we just got rid of turnOffFlash() too? Does the flash light stay on even when the camera app is hidden?  If not then we're done.  If it does stay on, then we should turn it off and on in some simpler way when the app is hidden and shown.  This can just be a special case for when we're in video recording mode and the flash light is on.

Is a gecko fix really necessary here?  I'd guess that we could fix this bug with better JavaScript and leave Gecko untouched.

Comment 11

[David Flanagan [:djf]]

Diego and Justin: if one of you is refactoring the flash management code (which badly needs it!) please try to address this bug while you do.

Comment 12

[Dafeng Xu]

when re-entry camera app, we will set camera parameters for three times. first is nsGonkCameraControl::Init, the call stack is as follow:
#0  mozilla::nsGonkCameraControl::PushParametersImpl (this=0x43b80100) at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/GonkCameraControl.cpp:886
#1  0x40d34c32 in mozilla::nsGonkCameraControl::Init (this=0x43b80100) at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/GonkCameraControl.cpp:265
#2  0x40d34cc2 in InitGonkCameraControl::Run (this=0x43b23c00) at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/GonkCameraControl.cpp:193
#3  0x411e34b4 in nsThread::ProcessNextEvent (this=0x43f47940, mayWait=<value optimized out>, result=0x446ffeaf)
    at /home/dafengxu/Project/ffos/B2G/gecko/xpcom/threads/nsThread.cpp:622
#4  0x411c2a04 in NS_ProcessNextEvent (thread=0x43b23c00, mayWait=true) at /home/dafengxu/Project/ffos/B2G/gecko/xpcom/glue/nsThreadUtils.cpp:238
#5  0x411e39d6 in nsThread::ThreadFunc (arg=<value optimized out>) at /home/dafengxu/Project/ffos/B2G/gecko/xpcom/threads/nsThread.cpp:250
#6  0x42183284 in _pt_root (arg=<value optimized out>) at /home/dafengxu/Project/ffos/B2G/gecko/nsprpub/pr/src/pthreads/ptthread.c:204
#7  0x400fec28 in __thread_entry (func=0x421831ed <_pt_root>, arg=0x443ee180, tls=<value optimized out>) at bionic/libc/bionic/pthread.c:217
#8  0x400fe77c in pthread_create (thread_out=<value optimized out>, attr=0xbe8b446c, start_routine=0x421831ed <_pt_root>, arg=0x443ee180)
    at bionic/libc/bionic/pthread.c:357
#9  0x00000000 in ?? ()
then, nsGonkCameraControl::SetupVideoMode will set camera parameters, the call stack is as follow:
#0  mozilla::nsGonkCameraControl::PushParametersImpl (this=0x43b80100) at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/GonkCameraControl.cpp:886
#1  0x40d339c0 in mozilla::nsGonkCameraControl::PushParameters (this=0x43b80100)
    at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/GonkCameraControl.cpp:534
#2  0x40d35576 in mozilla::nsGonkCameraControl::SetupVideoMode (this=0x43b80100, aProfile=<value optimized out>)
    at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/GonkCameraControl.cpp:1163
#3  0x40d355b6 in mozilla::nsGonkCameraControl::GetPreviewStreamVideoModeImpl (this=0x43b80100, aGetPreviewStreamVideoMode=0x43e6edf0)
    at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/GonkCameraControl.cpp:1374
#4  0x40d2f712 in mozilla::GetPreviewStreamVideoModeTask::Run (this=0x43e6edf0) at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/CameraControlImpl.h:594
#5  0x411e34b4 in nsThread::ProcessNextEvent (this=0x43f47940, mayWait=<value optimized out>, result=0x446ffeaf)
    at /home/dafengxu/Project/ffos/B2G/gecko/xpcom/threads/nsThread.cpp:622
#6  0x411c2a04 in NS_ProcessNextEvent (thread=0x43b80100, mayWait=true) at /home/dafengxu/Project/ffos/B2G/gecko/xpcom/glue/nsThreadUtils.cpp:238
#7  0x411e39d6 in nsThread::ThreadFunc (arg=<value optimized out>) at /home/dafengxu/Project/ffos/B2G/gecko/xpcom/threads/nsThread.cpp:250
#8  0x42183284 in _pt_root (arg=<value optimized out>) at /home/dafengxu/Project/ffos/B2G/gecko/nsprpub/pr/src/pthreads/ptthread.c:204
#9  0x400fec28 in __thread_entry (func=0x421831ed <_pt_root>, arg=0x443ee180, tls=<value optimized out>) at bionic/libc/bionic/pthread.c:217
#10 0x400fe77c in pthread_create (thread_out=<value optimized out>, attr=0xbe8b446c, start_routine=0x421831ed <_pt_root>, arg=0x443ee180)
    at bionic/libc/bionic/pthread.c:357
#11 0x00000000 in ?? ()
and then, the js will set camera parameters that were saved at the last exit: because the js interpreter is running in the main thread, so it will create another thread to set parameters, the main thread call stack is as follow:
#1  0x40c335b8 in mozilla::nsGonkCameraControl::PushParameters (this=0x43b9e240)
    at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/GonkCameraControl.cpp:534
#2  0x40c3441a in mozilla::nsGonkCameraControl::SetParameter (this=0x43b9e240, aKey=<value optimized out>, aValue=0xbeb5c050 "torch")
    at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/GonkCameraControl.cpp:559
#3  0x40c2ff0a in mozilla::CameraControlImpl::Set (this=0x43b9e240, aKey=3, aValue=<value optimized out>)
    at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/CameraControlImpl.cpp:47
#4  0x40c319ee in mozilla::nsDOMCameraControl::SetFlashMode (this=<value optimized out>, aFlashMode=..., aRv=...)
    at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/DOMCameraControl.cpp:103
#5  0x40f054f0 in set_flashMode (cx=0x43b725b0, obj=<value optimized out>, self=0x43b2c430, args=<value optimized out>)
    at /home/dafengxu/Project/ffos/B2G/objdir-gecko/dom/bindings/CameraControlBinding.cpp:244
#6  0x40f03c1c in genericSetter (cx=0x43b725b0, argc=<value optimized out>, vp=<value optimized out>)
    at /home/dafengxu/Project/ffos/B2G/objdir-gecko/dom/bindings/CameraControlBinding.cpp:1552
#7  0x414a9c92 in CallJSNative (cx=0x43b725b0, args=..., construct=<value optimized out>)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/jscntxtinlines.h:218
#8  Invoke (cx=0x43b725b0, args=..., construct=<value optimized out>) at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Interpreter.cpp:478
#9  0x414aa21c in Invoke (cx=0x43b725b0, obj=<value optimized out>, fval=..., argc=1, argv=0xbeb5c5d0, rval=...)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Interpreter.cpp:528
#10 js::InvokeGetterOrSetter (cx=0x43b725b0, obj=<value optimized out>, fval=..., argc=1, argv=0xbeb5c5d0, rval=...)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Interpreter.cpp:599
#11 0x41580ea0 in js::Shape::set (cx=0x43b725b0, obj=..., receiver=..., id=..., defineHow=0, vp=..., strict=false)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Shape-inl.h:88
#12 js::baseops::SetPropertyHelper (cx=0x43b725b0, obj=..., receiver=..., id=..., defineHow=0, vp=..., strict=false)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/jsobj.cpp:4651
#13 0x414a4b26 in SetPropertyOperation (cx=0x43b725b0, state=<value optimized out>) at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Interpreter.cpp:351
#14 Interpret (cx=0x43b725b0, state=<value optimized out>) at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Interpreter.cpp:2334
#15 0x414a9c44 in RunScript (cx=0x43b725b0, args=..., construct=<value optimized out>)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Interpreter.cpp:435
#16 Invoke (cx=0x43b725b0, args=..., construct=<value optimized out>) at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Interpreter.cpp:497
#17 0x4154ed98 in js::CallOrConstructBoundFunction (cx=0x43b725b0, argc=3199584928, vp=0xbeb5ca88)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/jsfun.cpp:1255
#18 0x414aabce in CallJSNative (cx=0x43b725b0, thisv=<value optimized out>, fval=..., argc=<value optimized out>, argv=0xbeb5cc80, rval=...)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/jscntxtinlines.h:218
#19 Invoke (cx=0x43b725b0, thisv=<value optimized out>, fval=..., argc=<value optimized out>, argv=0xbeb5cc80, rval=...)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Interpreter.cpp:478
#20 Invoke (cx=0x43b725b0, thisv=<value optimized out>, fval=..., argc=<value optimized out>, argv=0xbeb5cc80, rval=...)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/vm/Interpreter.cpp:528
#21 0x4151a240 in JS_CallFunctionValue (cx=0x43b725b0, objArg=<value optimized out>, fval=..., argc=1, argv=0xbeb5cc80, rval=0xbeb5cd38)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/src/jsapi.cpp:5019
#22 0x40cf5b46 in nsXPCWrappedJSClass::CallMethod (this=0x43b2b8b0, wrapper=<value optimized out>, methodIndex=<value optimized out>, info_=0x427880f0, 
    nativeParams=0xbeb5cdf8) at /home/dafengxu/Project/ffos/B2G/gecko/js/xpconnect/src/XPCWrappedJSClass.cpp:1423
#23 0x40cf4068 in nsXPCWrappedJS::CallMethod (this=0x433f7a00, methodIndex=3, info=0x427880f0, params=<value optimized out>)
    at /home/dafengxu/Project/ffos/B2G/gecko/js/xpconnect/src/XPCWrappedJS.cpp:588
#24 0x410f0290 in PrepareAndDispatch (self=0x43b2e220, methodIndex=<value optimized out>, args=<value optimized out>)
    at /home/dafengxu/Project/ffos/B2G/gecko/xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp:105
#25 0x410efa18 in SharedStub () from /home/dafengxu/Project/ffos/B2G/objdir-gecko/dist/bin/libxul.so
#26 0x40c32046 in GetCameraResult::Run (this=0x4474a3a0) at /home/dafengxu/Project/ffos/B2G/gecko/dom/camera/DOMCameraControl.cpp:487
#27 0x410e33ec in nsThread::ProcessNextEvent (this=0x403d8940, mayWait=<value optimized out>, result=0xbeb5cf27)
    at /home/dafengxu/Project/ffos/B2G/gecko/xpcom/threads/nsThread.cpp:622
#28 0x410c293c in NS_ProcessNextEvent (thread=0x43b9e240, mayWait=true) at /home/dafengxu/Project/ffos/B2G/gecko/xpcom/glue/nsThreadUtils.cpp:238
---Type <return> to continue, or q <return> to quit---
#29 0x40e3d086 in mozilla::ipc::MessagePump::Run (this=0x40301c10, aDelegate=0xbeb5d834)
    at /home/dafengxu/Project/ffos/B2G/gecko/ipc/glue/MessagePump.cpp:116
#30 0x40e3d0f2 in mozilla::ipc::MessagePumpForChildProcess::Run (this=0x40301c10, aDelegate=0xbeb5d834)
    at /home/dafengxu/Project/ffos/B2G/gecko/ipc/glue/MessagePump.cpp:234
#31 0x410fec88 in MessageLoop::RunInternal (this=0x1000001) at /home/dafengxu/Project/ffos/B2G/gecko/ipc/chromium/src/base/message_loop.cc:220
#32 0x410fecfe in MessageLoop::RunHandler (this=0xbeb5d834) at /home/dafengxu/Project/ffos/B2G/gecko/ipc/chromium/src/base/message_loop.cc:213
#33 MessageLoop::Run (this=0xbeb5d834) at /home/dafengxu/Project/ffos/B2G/gecko/ipc/chromium/src/base/message_loop.cc:187
#34 0x40deed70 in nsBaseAppShell::Run (this=0x433e3dc0) at /home/dafengxu/Project/ffos/B2G/gecko/widget/xpwidgets/nsBaseAppShell.cpp:161
#35 0x406c67da in XRE_RunAppShell () at /home/dafengxu/Project/ffos/B2G/gecko/toolkit/xre/nsEmbedFunctions.cpp:679
#36 0x40e3d0c0 in mozilla::ipc::MessagePumpForChildProcess::Run (this=0x40301c10, aDelegate=0xbeb5d834)
    at /home/dafengxu/Project/ffos/B2G/gecko/ipc/glue/MessagePump.cpp:201
#37 0x410fec88 in MessageLoop::RunInternal (this=0x433e3dc0) at /home/dafengxu/Project/ffos/B2G/gecko/ipc/chromium/src/base/message_loop.cc:220
#38 0x410fecfe in MessageLoop::RunHandler (this=0xbeb5d834) at /home/dafengxu/Project/ffos/B2G/gecko/ipc/chromium/src/base/message_loop.cc:213
#39 MessageLoop::Run (this=0xbeb5d834) at /home/dafengxu/Project/ffos/B2G/gecko/ipc/chromium/src/base/message_loop.cc:187
#40 0x406c6cce in XRE_InitChildProcess (aArgc=-1095378492, aArgv=0xbeb5d93c, aProcess=1077225472)
    at /home/dafengxu/Project/ffos/B2G/gecko/toolkit/xre/nsEmbedFunctions.cpp:516
#41 0x000086a0 in main (argc=7, argv=0xbeb5d9c4) at /home/dafengxu/Project/ffos/B2G/gecko/ipc/app/MozillaRuntimeMain.cpp:85
in this thread, the flash light is turned on, but in the init and SetupVideoMode thread, the flash light is turnd off, and the pamameters are not protected by lock, so the flash light state is not correct some times.

Comment 13

[Justin D'Arcangelo [:justindarc]]

djf: In separating out the model and view code, we decided to break the model up into two parts. One deals primarily with the "state" of the Camera and the other is for Camera "settings" that may more than likely be persisted. We will be addressing the flash state as part of this. I believe Wilson is implementing the flash and front/rear camera features for 1.3, so I will include him on this bug as well.

Comment 14

[Justin D'Arcangelo [:justindarc]]

dmarcos: I don't have Wilson's Bugzilla email address to add him to the CC list. If you have his email, could you try adding him. Thanks.

Comment 15

[Steven Yang [:styang]]

Dafeng, could you submit the new patch for review?

Comment 16

[James Zhang (Spreadtrum)]

v1.3 also has this issue.

Comment 17

[James Zhang (Spreadtrum)]

(In reply to Steven Yang [:styang] from comment #15)
> Dafeng, could you submit the new patch for review?

We have no better solution, need your help.

Comment 18

[Steven Yang [:styang]]

Gary, could you take a look on this?

Comment 19

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Okay~

Comment 20

[Evelyn Hung]

clear my ni since Gary is looking into it.

Comment 21

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

(In reply to Dafeng Xu from comment #0)
> Created attachment 826685 [details]
> the patch of this bug
> 
> User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like
> Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22
> 
> Steps to reproduce:
> 
> 1.open the camera app and switch to recording mode
> 2.turn on the flash light
> 3.press "Home" button and then re-entry the camera app
> 4.repeat the step '3' some times, you will find the flash light state is not
> correct
> 
> 
> Actual results:
> 
> the flash light is turned off
> 
> 
> Expected results:
> 
> the flash light should be turned on

Hi Dafeng and Steven,
   Sorry for late reply this issue.

   In recording (video) mode, some devices like iphone or sony will not turn on flash light when user recall Camera app but some ones will turn on.

   This is by design issue maybe need UX input to define suitable behavior for FxOS.
   So I do not think this is a blocker issue, this is feature request.


   see also bug 910631.

Comment 22

[James Zhang (Spreadtrum)]

Hi Steven,

   Our camera owner won't close this bug because flashlight status error cause this bug. Need work around.

Comment 23

[Steven Yang [:styang]]

Peipei, please help to reproduce this issue.

Comment 24

[Peipei Cheng (needinfo if you need my action)]

I reproduced this on Fugu device.

STR:
1. Launch Camera
2. Switch to Video mode
3. Turn on Flash
4. Send Camera to background
5. Bring Camera to frontend
   --> Flash is off.

Comment 25

[Peipei Cheng (needinfo if you need my action)]

(In reply to pcheng from comment #24)
> I reproduced this on Fugu device.
> 
> STR:
> 1. Launch Camera
> 2. Switch to Video mode
> 3. Turn on Flash
> 4. Send Camera to background
> 5. Bring Camera to frontend
>    --> Flash is off.

BTW, I can consistently reproduce this. Test build is Fugu V1.2.

Comment 26

[James Zhang (Spreadtrum)]

This bug is still fail on v1.3. Is there any reference phone with flash light for v1.3 ?
Sometime flash light is opened and sometimes it's closed.

Comment 27

[Preeti Raghunath(:Preeti)]

QA,

please test if this is common to fugu and helix to check if this common behavior.

Comment 28

[Matthew Vaughan]

On the Helix, the flash light will be off when re-entering the Camera app... as mentioned in comment 24. This occurred on the Helix 01/02/14 1.2 and Master (1.4), and on the Helix 01/14/14 1.3.

I cannot check a fugu device since we currently do not have one.

Environmental Variables:
Device: Helix v1.3 MOZ RIL
BuildID: 20140114004002
Gaia: 96c05def12ed7a9896b23f45398e361a97d2ce0e
Gecko: 29c5b8def408
Version: 28.0a2
Firmware Version: 20131217_ENG

Comment 29

[Hema Koka [:hema]]

We can take a look at persisting the flash setting as part of the camera features that we are looking into for 1.4

Comment 30

[Justin D'Arcangelo [:justindarc]]

It might be worthwhile to discuss having certain "persistable" settings for Camera in general. This was something we discussed as part of the refactor.

Comment 31

[Diego Marcos [:dmarcos]]

This is not straight forward. I created a bug to keep track of the more general problem of saving/loading user settings. bug 960611

Comment 32

[Jason Smith [:jsmith]]

This doesn't fall under the QC blocking feature list & DSDS feature list. Renoming.

Comment 33

[Preeti Raghunath(:Preeti)]

Hema

Please track if needed for camera.

Comment 34

[Hema Koka [:hema]]

Wilson,

With 960611 fixed and the new camera changes for flash (madai), this bug is probably a duplicate of flash settings (however there were no requirements around persistence for flash). Please confirm if we already addressed this. If not, we need to push this out to the next release.

Thanks
Hema

Comment 35

[Wilson Page [:wilsonpage]]

I observed the following behaviour on Helix (master):

1. Open camera and change to video mode flash 'on'
2. Flash light turns on.
3, Press homescreen button.
4. Observe flash remains on for about 5s before turning off.
5. Enter camera app again
6. Observe flash light turns back on.

Testing on Nexus-4 I observed the flash seemed to turn of a lot quicker than the Helix.

Comment 36

[Hema Koka [:hema]]

Not a blocker for 1.4, moving it to 1.5

Comment 37

[Mike Habicher [:mikeh] (high bugzilla latency)]

I can confirm the behaviour in comment 35, which seems to be correct.