Closed Bug 934445 Opened 11 years ago Closed 11 years ago

Fix Windows linking error in Release mode only when MOZ_CONTENT_SANDBOX is defined.

Categories

(Core :: Security, defect)

Product:
Core
Component:
Security
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

rev1
865 bytes, patch
bugzilla
: review+
Details | Diff | Splinter Review 
There's a marcro that uses a function that wasn't defined in the chromium sandbox shim code. The error wasn't coming up for me in debug builds, but showed up on tbpl because of release builds.  This bug is to fix that linking error.
Windows builds always previously failed with this build flag enabled by the way, so it's not a big deal but needs to be fixed :)
Attached patch rev1 — — Splinter Review 

        Attachment #826735 -
        Flags: review?(aklotz)

    
    

    
  
The code is just taken from chromium's logging.cpp directly. Verified it fixes the release mode problem on try already.

        Attachment #826735 -
        Flags: review?(aklotz) → review+

    
  
Whiteboard: [qa-]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: