Closed
Bug 934446
Opened 11 years ago
Closed 11 years ago
Test Messages contact input validation
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-v1.2 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v1.2 | --- | affected |
People
(Reporter: zcampbell, Assigned: bsilverberg)
Details
Attachments
(5 files, 1 obsolete file)
Test case: 1. Open Messages app 2. Into recipient field, type the name. 3. Press enter 4. Check that recipient changes to 'invalid' style 5. Tap recipient's name should make it editable again 6. Type into SMS message content 7. Check that 'send' button is disabled
|
||
Comment 1•11 years ago
|
||
I can work on this test, if that's ok.
|
||
Updated•11 years ago
|
Assignee: nobody → andrei.hutusoru
|
|
||
Comment 2•11 years ago
|
||
Attachment #828760 -
Flags: review?(zcampbell)
Attachment #828760 -
Flags: review?(moz.teodosia)
Attachment #828760 -
Flags: review?(florin.strugariu)
Attachment #828760 -
Flags: review?(bob.silverberg)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 828760 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13477 merge conflicts
Attachment #828760 -
Flags: review?(florin.strugariu) → review-
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 828760 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13477 Merge conflicts. Please fix and re-flag for review.
Attachment #828760 -
Flags: review?(bob.silverberg) → review-
|
|
||
Comment 5•11 years ago
|
||
Pointer to Github pull-request
|
|
||
Updated•11 years ago
|
Attachment #831469 -
Flags: review?(zcampbell)
Attachment #831469 -
Flags: review?(trifandreialin)
Attachment #831469 -
Flags: review?(bob.silverberg)
|
Reporter | |
Comment 6•11 years ago
|
||
Comment on attachment 831469 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13477 r+
Attachment #831469 -
Flags: review?(zcampbell) → review+
|
||
Comment 7•11 years ago
|
||
Comment on attachment 831469 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13477 r+
Attachment #831469 -
Flags: review?(trifandreialin) → review+
|
||
Updated•11 years ago
|
status-b2g-v1.2:
--- → affected
|
|
||
Updated•11 years ago
|
Attachment #831469 -
Flags: review?(bob.silverberg)
|
|
||
Comment 8•11 years ago
|
||
We need to add this to v1.2 too.
|
|
||
Comment 9•11 years ago
|
||
Pointer to Github pull-request
|
|
||
Updated•11 years ago
|
Attachment #831496 -
Flags: review?(trifandreialin)
Attachment #831496 -
Flags: review?(moz.teodosia)
Attachment #831496 -
Flags: review?(bob.silverberg)
|
|
||
Comment 10•11 years ago
|
||
Comment on attachment 831496 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13662 just a small nit and the pull is good to go
Attachment #831496 -
Flags: review?(trifandreialin) → review-
|
|
||
Comment 11•11 years ago
|
||
Updated the pull on v1.2
|
|
Assignee | |
Comment 12•11 years ago
|
||
Landed in v1.2: https://github.com/mozilla-b2g/gaia/commit/ace436c770c428f8ff3726fb3fb5780b3014f560
|
|
Assignee | |
Comment 13•11 years ago
|
||
Does anyone see any reason why this couldn't be enabled on TBPL as well?
|
|
Assignee | |
Updated•11 years ago
|
Attachment #831496 -
Flags: review?(moz.teodosia)
Attachment #831496 -
Flags: review?(bob.silverberg)
Attachment #831496 -
Flags: review+
|
|
Assignee | |
Comment 14•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #831658 -
Flags: review?(zcampbell)
|
|
Assignee | |
Comment 15•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 16•11 years ago
|
||
Comment on attachment 831662 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13669 PR to enable on TBPL on v1.2
Attachment #831662 -
Flags: review?(zcampbell)
|
|
||
Comment 17•11 years ago
|
||
Merged in master: https://github.com/bobsilverberg/gaia/commit/debb0c836144164ec016d9544ed93612ec9143de Merged in v1.2: https://github.com/bobsilverberg/gaia/commit/18fa0b8b421fc3db4f090a7ee673646e7857c994
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 18•11 years ago
|
||
Reverted v1.2 commit: https://github.com/mozilla-b2g/gaia/commit/9aa85835d8d9269b9d8cb56f4d8f49c21ba012fc This caused bustage on v1.2: https://tbpl.mozilla.org/php/getParsedLog.php?id=30565147&tree=Mozilla-B2g26-v1.2 Master/mozilla-central seems fine..!
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
|
|
Assignee | |
Comment 19•11 years ago
|
||
Changing the v1.2 status back to "affected".
|
|
||
Updated•11 years ago
|
Attachment #828760 -
Flags: review?(zcampbell)
Attachment #828760 -
Flags: review?(moz.teodosia)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #831658 -
Flags: review?(zcampbell)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #831662 -
Flags: review?(zcampbell)
|
|
||
Updated•11 years ago
|
Attachment #828760 -
Attachment is obsolete: true
|
|
||
Updated•11 years ago
|
Assignee: andrei.hutusoru → nobody
|
|
Assignee | |
Comment 20•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 21•11 years ago
|
||
Comment on attachment 8340577 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14230 This was enabled on tbpl in https://github.com/bobsilverberg/gaia/commit/18fa0b8b421fc3db4f090a7ee673646e7857c994, but then reverted in https://github.com/mozilla-b2g/gaia/commit/9aa85835d8d9269b9d8cb56f4d8f49c21ba012fc due to https://tbpl.mozilla.org/php/getParsedLog.php?id=30565147&tree=Mozilla-B2g26-v1.2. However, this test wasn't failing. Let's give it a try again.
Attachment #8340577 -
Flags: review?(viorela.ioia)
Attachment #8340577 -
Flags: review?(trifandreialin)
Attachment #8340577 -
Flags: review?(florin.strugariu)
Attachment #8340577 -
Flags: review?(andrei.hutusoru)
|
|
||
Comment 22•11 years ago
|
||
Comment on attachment 8340577 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14230 r+
Attachment #8340577 -
Flags: review?(trifandreialin) → review+
|
|
||
Updated•11 years ago
|
Attachment #8340577 -
Flags: review?(viorela.ioia) → review+
|
|
||
Updated•11 years ago
|
Attachment #8340577 -
Flags: review?(andrei.hutusoru) → review+
|
|
||
Updated•11 years ago
|
Attachment #8340577 -
Flags: review?(florin.strugariu) → review+
|
|
||
Comment 23•11 years ago
|
||
Merged in master: https://github.com/bobsilverberg/gaia/commit/debb0c836144164ec016d9544ed93612ec9143de V1.2 https://github.com/mozilla-b2g/gaia/commit/89a0530c2fb9bc967333fb04463d1f18bd74bdc5
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Assignee: nobody → bob.silverberg
You need to log in
before you can comment on or make changes to this bug.
Description
•