Closed Bug 934446 Opened 12 years ago Closed 12 years ago

Test Messages contact input validation

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.2 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v1.2 --- affected

People

(Reporter: zcampbell, Assigned: bsilverberg)

Details

Attachments

(5 files, 1 obsolete file)

Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13477
358 bytes, text/html
zcampbell
: review+
AlinT
: review+
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13662
358 bytes, text/html
bsilverberg
: review+
AlinT
: review-
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13668
358 bytes, text/html
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13669
358 bytes, text/html
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14230
358 bytes, text/html
Bebe
: review+
AlinT
: review+
AndreiH
: review+
viorela
: review+
Details
Test case: 1. Open Messages app 2. Into recipient field, type the name. 3. Press enter 4. Check that recipient changes to 'invalid' style 5. Tap recipient's name should make it editable again 6. Type into SMS message content 7. Check that 'send' button is disabled
I can work on this test, if that's ok.
Assignee: nobody → andrei.hutusoru
Attachment #828760 - Flags: review?(zcampbell)
Attachment #828760 - Flags: review?(moz.teodosia)
Attachment #828760 - Flags: review?(florin.strugariu)
Attachment #828760 - Flags: review?(bob.silverberg)
Comment on attachment 828760 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13477 merge conflicts
Attachment #828760 - Flags: review?(florin.strugariu) → review-
Comment on attachment 828760 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/13477 Merge conflicts. Please fix and re-flag for review.
Attachment #828760 - Flags: review?(bob.silverberg) → review-
Attachment #831469 - Flags: review?(zcampbell)
Attachment #831469 - Flags: review?(trifandreialin)
Attachment #831469 - Flags: review?(bob.silverberg)
Comment on attachment 831469 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13477 r+
Attachment #831469 - Flags: review?(zcampbell) → review+
Comment on attachment 831469 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13477 r+
Attachment #831469 - Flags: review?(trifandreialin) → review+
status-b2g-v1.2: --- → affected
Attachment #831469 - Flags: review?(bob.silverberg)
We need to add this to v1.2 too.
Attachment #831496 - Flags: review?(trifandreialin)
Attachment #831496 - Flags: review?(moz.teodosia)
Attachment #831496 - Flags: review?(bob.silverberg)
Comment on attachment 831496 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13662 just a small nit and the pull is good to go
Attachment #831496 - Flags: review?(trifandreialin) → review-
Updated the pull on v1.2
Does anyone see any reason why this couldn't be enabled on TBPL as well?
Attachment #831496 - Flags: review?(moz.teodosia)
Attachment #831496 - Flags: review?(bob.silverberg)
Attachment #831496 - Flags: review+
Attachment #831658 - Flags: review?(zcampbell)
Comment on attachment 831662 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13669 PR to enable on TBPL on v1.2
Attachment #831662 - Flags: review?(zcampbell)
Reverted v1.2 commit: https://github.com/mozilla-b2g/gaia/commit/9aa85835d8d9269b9d8cb56f4d8f49c21ba012fc This caused bustage on v1.2: https://tbpl.mozilla.org/php/getParsedLog.php?id=30565147&tree=Mozilla-B2g26-v1.2 Master/mozilla-central seems fine..!
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Changing the v1.2 status back to "affected".
status-b2g-v1.2: fixed → affected
Attachment #828760 - Flags: review?(zcampbell)
Attachment #828760 - Flags: review?(moz.teodosia)
Attachment #831658 - Flags: review?(zcampbell)
Attachment #831662 - Flags: review?(zcampbell)
Attachment #828760 - Attachment is obsolete: true
Assignee: andrei.hutusoru → nobody
Comment on attachment 8340577 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14230 This was enabled on tbpl in https://github.com/bobsilverberg/gaia/commit/18fa0b8b421fc3db4f090a7ee673646e7857c994, but then reverted in https://github.com/mozilla-b2g/gaia/commit/9aa85835d8d9269b9d8cb56f4d8f49c21ba012fc due to https://tbpl.mozilla.org/php/getParsedLog.php?id=30565147&tree=Mozilla-B2g26-v1.2. However, this test wasn't failing. Let's give it a try again.
Attachment #8340577 - Flags: review?(viorela.ioia)
Attachment #8340577 - Flags: review?(trifandreialin)
Attachment #8340577 - Flags: review?(florin.strugariu)
Attachment #8340577 - Flags: review?(andrei.hutusoru)
Comment on attachment 8340577 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14230 r+
Attachment #8340577 - Flags: review?(trifandreialin) → review+
Attachment #8340577 - Flags: review?(viorela.ioia) → review+
Attachment #8340577 - Flags: review?(andrei.hutusoru) → review+
Attachment #8340577 - Flags: review?(florin.strugariu) → review+
Merged in master: https://github.com/bobsilverberg/gaia/commit/debb0c836144164ec016d9544ed93612ec9143de V1.2 https://github.com/mozilla-b2g/gaia/commit/89a0530c2fb9bc967333fb04463d1f18bd74bdc5
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Assignee: nobody → bob.silverberg
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: