Closed Bug 934480 Opened 11 years ago Closed 11 years ago

Write a test for Messages app matching with contacts

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: zcampbell, Assigned: AndreiH)

References

Details

Attachments

(2 files)

PR https://github.com/mozilla-b2g/gaia/pull/13432
46 bytes, text/x-github-pull-request
zcampbell
: review+
Details | Review
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13660
358 bytes, text/html
bsilverberg
: review+
Bebe
: review+
Details 
1. Push a contact to the device
2. Open messages app
3. Type name of the contact with keyboard
4. Press enter on keyboard
5. Check that the contact is matched correctly.
Assignee: nobody → andrei.hutusoru
Tested this also on desktopb2g, works fine
Attachment #828066 - Flags: review?(zcampbell)
Attachment #828066 - Flags: review?(trifandreialin)
Attachment #828066 - Flags: review?(moz.teodosia)
Attachment #828066 - Flags: review?(florin.strugariu)
Attachment #828066 - Flags: review?(moz.teodosia) → review-
Updated the pull!
Attachment #828066 - Flags: review?(zcampbell)
Attachment #828066 - Flags: review?(trifandreialin)
Attachment #828066 - Flags: review?(florin.strugariu)
Attachment #828066 - Flags: review-
Attachment #828066 - Flags: review+
Merging into master:
https://github.com/mozilla-b2g/gaia/commit/321707b8a78103e77c69c9793f1b69b491c28552

Note for v1.2, I *think* uplift of this to v1.2 will depend upon https://bugzilla.mozilla.org/show_bug.cgi?id=920546
Adding v1.2 whiteboard entry.
Whiteboard: [v1.2-test-checkin-needed]
John, can you please help with the uplift to v1.2? :)
Flags: needinfo?(jhford)
Ryan/John, I'm not sure this is ready for an uplift yet. That whiteboard entry was meant as a marker to us (Web QA) to follow up with an uplift. That may require additional changes to work in v1.2.  For now I think we are going to uplift manually, mostly via PRs.

Thanks very much for noticing and staying on top of it though. :)
status-b2g-v1.2: --- → affected
Whiteboard: [v1.2-test-checkin-needed]
Should I uplift this or not?
Flags: needinfo?(jhford)
Pointer to Github pull-request
Attachment #831481 - Flags: review?(trifandreialin)
Attachment #831481 - Flags: review?(moz.teodosia)
Attachment #831481 - Flags: review?(bob.silverberg)
Comment on attachment 831481 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13660

Comments in the PR.
Attachment #831481 - Flags: review?(bob.silverberg) → review-
Attachment #831481 - Flags: review?(trifandreialin) → review-
Blocks: 939105
Comment on attachment 831481 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13660

The pull for v1.2 has been updated. Please review now
Attachment #831481 - Flags: review?(trifandreialin)
Attachment #831481 - Flags: review?(florin.strugariu)
Attachment #831481 - Flags: review?(bob.silverberg)
Attachment #831481 - Flags: review-
Comment on attachment 831481 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13660

fix the Pep8 and we are OKI
Attachment #831481 - Flags: review?(florin.strugariu) → review+
Comment on attachment 831481 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13660

r+ assuming the one pep8 issue is fixed
Attachment #831481 - Flags: review?(bob.silverberg) → review+
Attachment #831481 - Flags: review?(trifandreialin)
Attachment #831481 - Flags: review?(moz.teodosia)
Landed in v1.2: https://github.com/mozilla-b2g/gaia/commit/71b9eefcae499bdc0b9aa3b82a3ff98f4df5ea57
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v1.2: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: