Closed
Bug 934480
Opened 11 years ago
Closed 11 years ago
Write a test for Messages app matching with contacts
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-v1.2 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | fixed |
People
(Reporter: zcampbell, Assigned: AndreiH)
References
Details
Attachments
(2 files)
1. Push a contact to the device 2. Open messages app 3. Type name of the contact with keyboard 4. Press enter on keyboard 5. Check that the contact is matched correctly.
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → andrei.hutusoru
Assignee | ||
Comment 1•11 years ago
|
||
Tested this also on desktopb2g, works fine
Attachment #828066 -
Flags: review?(zcampbell)
Attachment #828066 -
Flags: review?(trifandreialin)
Attachment #828066 -
Flags: review?(moz.teodosia)
Attachment #828066 -
Flags: review?(florin.strugariu)
Updated•11 years ago
|
Attachment #828066 -
Flags: review?(moz.teodosia) → review-
Assignee | ||
Comment 2•11 years ago
|
||
Updated the pull!
Reporter | ||
Updated•11 years ago
|
Attachment #828066 -
Flags: review?(zcampbell)
Attachment #828066 -
Flags: review?(trifandreialin)
Attachment #828066 -
Flags: review?(florin.strugariu)
Attachment #828066 -
Flags: review-
Attachment #828066 -
Flags: review+
Reporter | ||
Comment 3•11 years ago
|
||
Merging into master: https://github.com/mozilla-b2g/gaia/commit/321707b8a78103e77c69c9793f1b69b491c28552 Note for v1.2, I *think* uplift of this to v1.2 will depend upon https://bugzilla.mozilla.org/show_bug.cgi?id=920546
Comment 5•11 years ago
|
||
John, can you please help with the uplift to v1.2? :)
Flags: needinfo?(jhford)
Comment 6•11 years ago
|
||
Ryan/John, I'm not sure this is ready for an uplift yet. That whiteboard entry was meant as a marker to us (Web QA) to follow up with an uplift. That may require additional changes to work in v1.2. For now I think we are going to uplift manually, mostly via PRs. Thanks very much for noticing and staying on top of it though. :)
Updated•11 years ago
|
status-b2g-v1.2:
--- → affected
Whiteboard: [v1.2-test-checkin-needed]
Assignee | ||
Comment 8•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #831481 -
Flags: review?(trifandreialin)
Attachment #831481 -
Flags: review?(moz.teodosia)
Attachment #831481 -
Flags: review?(bob.silverberg)
Comment 9•11 years ago
|
||
Comment on attachment 831481 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13660 Comments in the PR.
Attachment #831481 -
Flags: review?(bob.silverberg) → review-
Updated•11 years ago
|
Attachment #831481 -
Flags: review?(trifandreialin) → review-
Assignee | ||
Comment 10•11 years ago
|
||
Comment on attachment 831481 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13660 The pull for v1.2 has been updated. Please review now
Attachment #831481 -
Flags: review?(trifandreialin)
Attachment #831481 -
Flags: review?(florin.strugariu)
Attachment #831481 -
Flags: review?(bob.silverberg)
Attachment #831481 -
Flags: review-
Comment 11•11 years ago
|
||
Comment on attachment 831481 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13660 fix the Pep8 and we are OKI
Attachment #831481 -
Flags: review?(florin.strugariu) → review+
Comment 12•11 years ago
|
||
Comment on attachment 831481 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13660 r+ assuming the one pep8 issue is fixed
Attachment #831481 -
Flags: review?(bob.silverberg) → review+
Updated•11 years ago
|
Attachment #831481 -
Flags: review?(trifandreialin)
Attachment #831481 -
Flags: review?(moz.teodosia)
Comment 13•11 years ago
|
||
Landed in v1.2: https://github.com/mozilla-b2g/gaia/commit/71b9eefcae499bdc0b9aa3b82a3ff98f4df5ea57
You need to log in
before you can comment on or make changes to this bug.
Description
•