934483 - [e.me] The type reported for "Skyfall" has changed from "Movies" to "BrandInfo"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Zac C (:zac)]

+++ This bug was initially created as a clone of Bug #927023 +++

STR:

1. Search for "skyfall" using the e.me bar.

Expected result: "Everything skyfall (Movies)" appears under the bar.
Actual result: "Everything skyfall (BrandInfo)" appears under the bar.


This has regressed again
Hamachi:
Gecko  http://hg.mozilla.org/mozilla-central/rev/47c8e9b16918
Gaia  00cd7534afb8d727531c7a939e54e382b3be713a
BuildID 20131103040200
Version 28.0a1

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13356

Pointer to Github pull-request

Comment 2

[Jason Smith [:jsmith]]

The e.me guys are at the same work week I'm at right now, so let me see if I can someone to look at this.

Comment 3

[Zac C (:zac)]

Bebe this is a bug report, don't attach test fixes to the bug report! It will get mixed up with the actual bug fix patch.

Raise a separate issue in the UI Tests component then attach.

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

I want to bring into question this ui test.

Entity classification changes and adapts frequently and therefore is essentially unpredictable.
For example, tomorrow a TV series might come out called "skyfall", or a new James Bond fragrance, the soundtrack might make record sales. Then, "Movies" will not be the type displayed for this query.

I think we can't have a ui test dependent on that sort of data.

Comment 5

[Zac C (:zac)]

I can change it to a more stable search term but we will keep the test case.

Comment 6

[Bob Silverberg [:bsilverberg]]

I don't think a bug has been opened for updating the test case so it doesn't rely on the text of the category. Can someone please do that before this is forgotten?

Comment 7

[Zac C (:zac)]

I filed bug #935915 but I still want to see this fixed.

Last time it happened bug #927023 it was a 'server error' .. so it's clearly an e.me problem and can be fixed.

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

Fixed. Can you verify?

Comment 9

[Zac C (:zac)]

Fixed!