Make cycle collector OOM assertions fatal in debug builds

RESOLVED FIXED in mozilla28

Status

()

Core
XPCOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: bjacob)

Tracking

unspecified
mozilla28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Reporter)

Updated

4 years ago
Summary: Make OOM assertions fatal in debug builds → Make cycle collector OOM assertions fatal in debug builds
(Reporter)

Comment 1

4 years ago
Created attachment 827445 [details] [diff] [review]
bjacob's patch

This looked green on try, so I'll land this when inbound is open again.
Attachment #827445 - Flags: review+
(Reporter)

Updated

4 years ago
Assignee: nobody → bjacob
https://hg.mozilla.org/mozilla-central/rev/e078b92f7db1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
(Reporter)

Updated

4 years ago
Depends on: 935419
(Reporter)

Comment 4

4 years ago
Created attachment 828356 [details] [diff] [review]
make the ScanRoots assertion non-fatal, fix indentation

This is triggering quite a bit on Win7 debug M2 for whatever reason, and I don't have any time to look into it this week, so let's just avoid bothering the sheriffs.
Attachment #828356 - Flags: review?(bugs)

Comment 5

4 years ago
Do you have log links to the failures?
(Reporter)

Comment 6

4 years ago
I should have said, the failures are in bug 935419.

Updated

4 years ago
Attachment #828356 - Flags: review?(bugs) → review+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.