934583 - [B2G][Dialer] The phone number is highlighted in red not orange when initiating a call from the call log

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: 2013-11-04-11-01-03.png

Description:
The number is highlighted in red not orange when initiating a call from the call log.

Repro Steps:
1)  Updated Buri to Build ID: 20131030004003
2)  Tap on the "Dialer" icon.
3)  Tap on the "Call log" icon.
4)  Tap on a outgoing or answered call in the call log.
5)  Look at the phone number on the contact's details page.

Actual:
The phone number is highlighted in red like it was a missed call.

Expected:
The phone number is highlighted in orange.

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL
Build ID: 20131030004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/4fbe1b01ed63
Gaia: a788ea1a3e04716938bd41a559c36a831cf1190b
Platform Version: 26.0a2
RIL Version: 01.01.00.019.264 

Notes:
Repro frequency: 100%
Link to failed test case:
See attached: screenshot

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

Link to failed test cases: https://moztrap.mozilla.org/runtests/run/2528/env/347/?&pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=2275&filter-id=2276&filter-suite=130

This issue occurs on Leo V 1.1.0 COM RIL

Environmental Variables
Device: Leo v 1.1.0 COM RIL
Build ID: 20131024041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/e4cb5a852e3d
Gaia: 39b0203fa9809052c8c4d4332fef03bbaf0426fc
Platform Version: 18.1
RIL Version: 01.01.00.019.264 

The number is highlighted in red in the Contact's details page when initiating a call from the call log.

Comment 2

[Anthony Ricaud (:rik)]

I see that we have a .remark class in the code that adds a red color (#d20000 exactly).

Francisco: Do you know if there is another flow that uses this class to highlight a number? If no, we can just change this to orange.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Yes it's used for highlighting the phone number when coming from the call log.

If a user has two phones, the one marked in the call log should be highlighted with this red. That's happening by passing parameters to the url that you open in the contacts iframe, actually we should pass a get parameter called 'tel'.

Btw, I'm checking that's not working :( so we do have a bug in the contacts when invoked in the iframe.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

rereading Anthony's question, yes, it's the only path, so we can change that class.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Hi Viky,

do you know what's the orange value that Anthony is asking for?

Comment 6

[Victoria Gerchinhoren [:vicky]]

Hi Guys,
The orange in small text should be: #FF4E00

For further reference you can always find info here: http://www.mozilla.org/en-US/styleguide/products/firefox-os/color/

Thanks!

Comment 7

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15468

Hardest. Patch. Ever.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8361765 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15468

Thanks Anthony for your hard work ... oh wait ;)

Anyway thanks for taking care.

Comment 9

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/8a87693b512c595db86cd3d1f44660d66843eceb